Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporary cert_path not cleaned in piptool.py #150

Closed
qsogia opened this issue Dec 27, 2018 · 5 comments
Closed

Temporary cert_path not cleaned in piptool.py #150

qsogia opened this issue Dec 27, 2018 · 5 comments
Labels
Can Close? Will close in 30 days if there is no new activity

Comments

@qsogia
Copy link

qsogia commented Dec 27, 2018

The temporary cert_path used to extract cert from wheel is not cleaned after use. This causes /tmp to continue collecting a number of these when not properly sandboxed.
qsogia pushed a commit to qsogia/rules_python that referenced this issue Dec 27, 2018
Cleanup temporary folder created for cert file extracted from wheel (b…
8e0c31d 
…azelbuild#150)

The piptool run is not properly sandboxed and the temporary folder
created during extraction of cacert.pem does not get cleaned on
exit. This leads to accumulation in /tmp and may result in out of
space errors over long a period of time.
@qsogia
Copy link
Author

qsogia commented Dec 30, 2018

There is PR that I have put out. I also signed the CLA, but the no-CLA label did not get removed.

@thundergolfer
Copy link

thundergolfer commented May 15, 2019 •
edited
Loading

@Kaizers I have also recently discovered this. Thanks for doing the PR, linking it here: #169

Did you tried re-signing the CLA? I've seen it be finicky.

@AustinSchuh
Copy link
Contributor

I'm continuing on the work that Kaizer was doing. The patch I sent out has the CLA signed and should be all ready pending review.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days.
Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_python!

@github-actions github-actions bot added the Can Close? Will close in 30 days if there is no new activity label Apr 14, 2021
@AustinSchuh
Copy link
Contributor

#169 closed, so I think we can close this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Can Close? Will close in 30 days if there is no new activity
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@AustinSchuh @qsogia @hrfuller @thundergolfer