Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed glob includes for ignore_root_user_error #1037

Merged
merged 4 commits into from
Feb 2, 2023

Conversation

linzhp
Copy link
Contributor

@linzhp linzhp commented Feb 1, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

#907 put the comments as elements in the include list of the glob when ignore_root_user_error is True, causing test build failures

What is the new behavior?

Make comments as comments

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@illicitonion Are you sure you want to put .pyc files in the includes? The description of #907 indicates that you wanted to exclude them, but you ended up including them.

@illicitonion
Copy link
Contributor

Oops, you're correct, I messed that up when resolving a merge conflict - thanks for the heads up! Fixed in #1038

@linzhp linzhp closed this Feb 1, 2023
@linzhp linzhp deleted the ignore_root_user_error branch February 1, 2023 17:00
@linzhp linzhp restored the ignore_root_user_error branch February 2, 2023 01:11
@linzhp linzhp reopened this Feb 2, 2023
@linzhp
Copy link
Contributor Author

linzhp commented Feb 2, 2023

Part of this PR has been superseded by #1038, but I still want to keep the tests to cover the case of ignore_root_user_error = True to prevent future regression.

Copy link
Collaborator

@f0rmiga f0rmiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you just add a README to the test explaining why the test exists?

@f0rmiga f0rmiga merged commit 0e55ced into bazelbuild:main Feb 2, 2023
@linzhp linzhp deleted the ignore_root_user_error branch February 2, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants