Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gazelle): empty list #2099

Merged
merged 1 commit into from
Dec 4, 2024
Merged

fix(gazelle): empty list #2099

merged 1 commit into from
Dec 4, 2024

Conversation

hunshcn
Copy link
Contributor

@hunshcn hunshcn commented Jul 29, 2024

This is a code error (from typo).

@hunshcn
Copy link
Contributor Author

hunshcn commented Jul 29, 2024

Reported by @Whoaa512 .

I didn't modify changelog and test because although I believe this is a mistake, I didn't think of how to trigger this problem.

Did you trigger this error in some scenes? @Whoaa512

@Whoaa512
Copy link
Contributor

No, I just noticed because I was referencing at rules_python while building a new language plugin.

@aignas
Copy link
Collaborator

aignas commented Dec 3, 2024

@hunshcn, is this still needed? If so, could you please rebase?

@hunshcn hunshcn marked this pull request as ready for review December 4, 2024 03:25
@hunshcn hunshcn requested a review from aignas as a code owner December 4, 2024 03:25
@hunshcn
Copy link
Contributor Author

hunshcn commented Dec 4, 2024

Should I modify changelog? There should be no user-oriented modification.

@aignas
Copy link
Collaborator

aignas commented Dec 4, 2024

I think no need to change the changelog, FYI @dougthor42.

dougthor42
dougthor42 approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@dougthor42 dougthor42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, no update to changelog needed.

@aignas aignas added this pull request to the merge queue Dec 4, 2024
Merged via the queue into bazelbuild:main with commit 60da4a3 Dec 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aignas aignas aignas approved these changes

@dougthor42 dougthor42 dougthor42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hunshcn @Whoaa512 @aignas @dougthor42