feat(proto): shim to upstream for py_proto_library #2581
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this PR we attempt to remove our implementation of py_proto_library and we just forward the calls to the upstream. Hopefully this fixes bazelbuild#2543.
|
I noticed the proto version was updated -- does this mean 29.3 has all the parts we need, so we can put this shim in now? |
|
I think we could do it with the old version, but the fix that @tpudlik put in is not in the upstream, so I am wondering what we should do... |
|
Maybe we can provide users with a small patch before it gets picked up by the protocolbuffers team. I think it would be the most we could do from our side. |
|
Yes, sorry, I've not contributed it yet! Sorry, it slipped my mind. I'll send a CL (PR) this week, but it will take a little while to make it into a released version, of course. |
rickeylev
added
the
need: upstream support
copybara-service bot
pushed a commit
to protocolbuffers/protobuf
that referenced
this pull request
Feb 1, 2025
Previously, the import path within the runfiles was only correct for the case `--legacy_external_runfiles=True` (which copied the runfiles into `$RUNFILES/<main repo>/external/<external repo>/<path>` in addition to `$RUNFILES/<external repo>/<path>`. This flag was flipped to False in Bazel 8.0.0. This is identical to the change made to rules_python in bazelbuild/rules_python#2516. Work towards bazelbuild/rules_python#2581. PiperOrigin-RevId: 721941173
copybara-service bot
pushed a commit
to protocolbuffers/protobuf
that referenced
this pull request
Feb 1, 2025
Previously, the import path within the runfiles was only correct for the case `--legacy_external_runfiles=True` (which copied the runfiles into `$RUNFILES/<main repo>/external/<external repo>/<path>` in addition to `$RUNFILES/<external repo>/<path>`. This flag was flipped to False in Bazel 8.0.0. This is identical to the change made to rules_python in bazelbuild/rules_python#2516. Work towards bazelbuild/rules_python#2581. PiperOrigin-RevId: 721941173
copybara-service bot
pushed a commit
to protocolbuffers/protobuf
that referenced
this pull request
Feb 1, 2025
Previously, the import path within the runfiles was only correct for the case `--legacy_external_runfiles=True` (which copied the runfiles into `$RUNFILES/<main repo>/external/<external repo>/<path>` in addition to `$RUNFILES/<external repo>/<path>`. This flag was flipped to False in Bazel 8.0.0. This is identical to the change made to rules_python in bazelbuild/rules_python#2516. Work towards bazelbuild/rules_python#2581. PiperOrigin-RevId: 721941173
copybara-service bot
pushed a commit
to protocolbuffers/protobuf
that referenced
this pull request
Feb 3, 2025
Previously, the import path within the runfiles was only correct for the case `--legacy_external_runfiles=True` (which copied the runfiles into `$RUNFILES/<main repo>/external/<external repo>/<path>` in addition to `$RUNFILES/<external repo>/<path>`. This flag was flipped to False in Bazel 8.0.0. This is identical to the change made to rules_python in bazelbuild/rules_python#2516. Work towards bazelbuild/rules_python#2581. PiperOrigin-RevId: 722690855
|
Closing in favour of #2604 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we attempt to remove our implementation of py_proto_library
and we just forward the calls to the upstream.
Hopefully this fixes #2543.
Work towards #2173.