Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing bazelbuild/bazel/issues/7793 #249

Closed
wants to merge 1 commit into from

Conversation

BlueHotDog
Copy link

Making rules work for bazel > 0.26
not sure how to make this backwards comp.

Making rules work for bazel > 0.26
not sure how to make this backwards comp.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@damienmg
Copy link
Collaborator

damienmg commented Sep 5, 2019

Hi, Bazel 0.27 is working at head according to our CI. Can you be a bit more specific on what is broken?

@BlueHotDog
Copy link
Author

This is the relevant issue in Bazel:
bazelbuild/bazel#7793

@damienmg
Copy link
Collaborator

Ok that sounds good to me, thanks for sending this PR. We cannot accept your contribution if you do not sign the CLA.

@BlueHotDog
Copy link
Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@damienmg
Copy link
Collaborator

Ok I haven't realized but this is already in it. A few lines above in kwargs, the "ctx" argument is inserted on specific version of Bazel. I'll go ahead and close this PR.

Sorry for all the back and forth and I not realizing there was a Buildkite failure.

@damienmg damienmg closed this Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants