Document IntelliJ plugin incompatibility with custom rule names #1047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gergelyfabian
force-pushed
the
document_intellij_plugin_hard_coded_targets
branch
from
06b74d6 to
61ca881
Compare
gergelyfabian
force-pushed
the
document_intellij_plugin_hard_coded_targets
branch
from
61ca881 to
ab1dcb1
Compare
ittaiz
reviewed
May 20, 2020
docs/customizable_phase.md
Outdated
|
|
||
| Bazel IntelliJ plugin has hard-coded the names of rules_scala targets that it detects as Scala targets: | ||
|
|
||
| https://github.com/bazelbuild/intellij/blob/master/scala/src/com/google/idea/blaze/scala/ScalaBlazeRules.java#L32-L37 |
There was a problem hiding this comment.
Maybe use a permalink in case it moves?
SocksDevil
pushed a commit
to SocksDevil/rules_scala
that referenced
this pull request
Jul 6, 2020
…lbuild#1047) * Document IntelliJ plugin incompatibility with custom rule names * Changing reference to intellij plugin codebase to a permalink
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding documentation about IntelliJ plugin incompatibility as requested in bazelbuild/intellij#1824.
Motivation
We need to document that custom rule names won't work with IntelliJ which is not obvious.