Fix JacocoInstrumenter compilation with JDK 13+ #1402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simuons
approved these changes
Jun 6, 2022
simuons
approved these changes
Jun 6, 2022
There was a problem hiding this comment.
Thanks @dmivankov,
I don't think that test failure is related to your changes. Could you please close and reopen pr to trigger build again?
Following bazelbuild/bazel#10214 bazelbuild/bazel@0216ee5 FileSystems.newFileSystem becomes ambiguous on 2nd parameter when it is null. So adding explicit type annotation. https://docs.oracle.com/javase/7/docs/api/java/nio/file/FileSystems.html
|
Close-open didn't retrigger the build, so tried to rebase. Still fails the same way without a lot of error logs, so not clear if specific to this PR or to the test system. |
|
Yes I see. Though it complains on different test: We will investigate why it happens. |
liucijus
approved these changes
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix JacocoInstrumenter compilation with JDK 13+
Following
bazelbuild/bazel#10214
bazelbuild/bazel@0216ee5
FileSystems.newFileSystem becomes ambiguous on 2nd parameter when it is null.
So adding explicit type annotation.
https://docs.oracle.com/javase/7/docs/api/java/nio/file/FileSystems.html
Tested via
bazel build @io_bazel_rules_scala//src/java/io/bazel/rulesscala/coverage/instrumenter:instrumenterMotivation
Being able to run coverage with JDK 17