Catch macro expansion exceptions in ScalacWorker #1489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liucijus
requested changes
Apr 3, 2023
There was a problem hiding this comment.
Thanks, @thirtyseven! Would you be able to contribute an end to end test?
I can take a stab at it, are there any existing e2e tests for the existing case of handling |
|
It doesn't appear that there are any, I'll try to add e2e tests for both cases. |
|
@liucijus Actually, I couldn't figure out how to reproduce the previous |
liucijus
approved these changes
Apr 4, 2023
simuons
approved these changes
Apr 4, 2023
|
Thanks for the review! FYI I do not have commit access so will need someone else to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Catch scalac exceptions that occur during expansion of user macros so that the entire worker doesn't crash.
Motivation
Fixes #1488