For Windows: Fix to enable scala_test and scala_binary outputs to be executed on Windows #1502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Passing the correct path forms (i.e. rpathlocation vs rootpath) to Windows Launcher. This enables running scala_test and scala_binary outputs through bazel on windows.
liucijus
requested changes
Jun 26, 2023
scala/private/common.bzl
Outdated
| #generates rpathlocation that should be used with the rlocation() at runtime. (rpathlocations start with repo name) | ||
| #rootpath arg expects "rootpath" format (i.e. relative to runfilesDir/workspacename). Rootpath can be obtained by $rootpath macro or File.short_path | ||
| def rpathlocation_from_rootpath(ctx, rootpath): | ||
| p = paths.normalize(ctx.workspace_name + "/" + rootpath) |
|
|
||
| cpfile = ctx.actions.declare_file("%s.classpath" % ctx.label.name) | ||
| ctx.actions.write(cpfile, classpath) | ||
|
|
||
| specifiedEnv = {} |
There was a problem hiding this comment.
Could you add code comment explaining this change. Also, please consider using https://bazel.build/rules/lib/globals/all#getattr with a default value
- Added comment on use of env in _write_executable_windows() - Removed unecessary var in rpathlocation_from_rootpath()
liucijus
approved these changes
Jun 30, 2023
simuons
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For Windows, this PR fixes issue where outputs of scala_test and scala_binary are failing when ran with 'bazel run' and 'bazel test'. When trying to do run or test, Bazel shows error like:
The Fix: On Windows, Bazel’s Java Launcher was being passed paths in the wrong ‘form’. The launcher expects rpathlocation form for some paths and rootpath form for others. Fix is to pass the right forms of the paths to the LauncherFileWriter which in turn passes correct paths into the Launcher.
Motivation
scala_test and scala_binary should work properly on Windows
Seems to have been caused by #1313
Should also fix #1497
Test/Reproduction
The following can be used as a demonstration test on windows (will fail before this PR):
bazel test //test/RunScalaBinary --enable_runfiles --extra_toolchains=//scala:minimal_direct_source_depsNote that: 'bazel test' requires --enable_runfiles to be set on Windows.
Also note that many other tests fail in Windows, but fixes for those are for a separate PR.