Remove binary artifacts due to security policy violation #1538
Conversation
There was a problem hiding this comment.
@mateuszkuta256 thanks for taking this!
Please check if using implicit jar output can be used in places where original external jar was imported, like in this example
There was a problem hiding this comment.
@mateuszkuta256 I think we are very close to get this merged, please address the comments. Thanks for the patience.
test/src/main/scala/scalarules/test/scala_import/nl/BUILD.bazel
Outdated
Show resolved
Hide resolved
test/src/main/scala/scalarules/test/twitter_scrooge/thrift/bare_jar_thrifts/BUILD
Show resolved
Hide resolved
| external_jars = [ | ||
| "bare-thrift-1.jar", | ||
| ], | ||
| srcs = ["//test/src/main/resources/scalarules/test:Bar.thrift"], |
There was a problem hiding this comment.
same as above. Do you know why the second test is needed?
There was a problem hiding this comment.
now I reference .jar directly
the second test is meant for test_version.sh, apparently every test running against various versions has its copy there
test/src/main/scala/scalarules/test/twitter_scrooge/thrift/bare_jar_thrifts/bare_jar_2/BUILD
Show resolved
Hide resolved
| @@ -9,7 +9,7 @@ thrift_library( | |||
|
|
|||
| scrooge_scala_import( | |||
| name = "thrift3_import", | |||
| scala_jars = ["thrift3_scrooge.jar"], | |||
| scala_jars = ["//test/src/main/scala/scalarules/test/twitter_scrooge:scrooge3"], | |||
There was a problem hiding this comment.
I'd like a comment (in the code) here about what's going on. Just by looking at the test is very hard to understand what's going on and how is it being tested.
There was a problem hiding this comment.
kk, hope the comment I added is useful
thx for your patience too ;D
Description
This PR removes .jar files that trigger security violation alert
Motivation
Resolves issue created by Allstar bot #1458