Skip to content
This repository has been archived by the owner on Sep 16, 2021. It is now read-only.

ci: lower memory ceiling #380

Closed
wants to merge 1 commit into from
Closed

ci: lower memory ceiling #380

wants to merge 1 commit into from

Conversation

filipesilva
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Both #327 and #378 have circleci test jobs being killed:

Server terminated abruptly (error code: 14, error message: '', log file: '/home/circleci/.cache/bazel/_bazel_circleci/cced162ff126e466524550c57f0d7df5/server/jvm.out')

According to the note in

# Since the default CircleCI container has only 4G, limiting the memory
# is required to keep Bazel from exhausting the memory. These values
# are determined experimentally. If the Bazel process crashes without
# any error messages then the --local_resources and --host_jvm_args
# memory should be reduced. If the Bazel process errors out within
# a "JVM out of memory" error then the --host_jvm_args memory should
# be increased.
this means the memory limit should be reduced.

What is the new behavior?

Lower memory limit.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Both #327 and #378 have circleci `test` jobs being killed:
```
Server terminated abruptly (error code: 14, error message: '', log file: '/home/circleci/.cache/bazel/_bazel_circleci/cced162ff126e466524550c57f0d7df5/server/jvm.out')
```

According to the note in https://github.com/bazelbuild/rules_typescript/blob/4a087c084cab78e610f91764db52e705aefa1814/.circleci/bazel.rc#L32-L38 this means the memory limit should be reduced.
@alexeagle
Copy link
Contributor

Sent for internal g3 review/submit

@gregmagolan
Copy link
Contributor

@filipesilva If you rebase #378 and #327 to master they will get the xlarge resource_class in CircleCI for the test job and not run into memory issues anymore. This change isn't needed. I should probably remove the comment in .bazelrc as its based on trial and error not guaranteed to work in any case since the 4GB container was at the point with the test job that there may have been no memory configuration that would have allowed it to pass.

@filipesilva filipesilva deleted the lower-mem-circleci branch January 11, 2019 17:12
kyliau pushed a commit that referenced this pull request Jan 12, 2019
Both #327 and #378 have circleci `test` jobs being killed:
```
Server terminated abruptly (error code: 14, error message: '', log file: '/home/circleci/.cache/bazel/_bazel_circleci/cced162ff126e466524550c57f0d7df5/server/jvm.out')
```

According to the note in https://github.com/bazelbuild/rules_typescript/blob/4a087c084cab78e610f91764db52e705aefa1814/.circleci/bazel.rc#L32-L38 this means the memory limit should be reduced.

Closes #380

PiperOrigin-RevId: 228881108
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants