Use extra-light instead of thin for line numbers #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbatsov#305 was a great but thin is *too* thin for fonts which support many weights. This replaces thin by extra-light, which is still visibly different from the normal weight but also still legible. In fact, it's so thin, it's not even documented, see https://github.com/emacs-mirror/emacs/blob/master/src/font.c#L71 https://www.gnu.org/software/emacs/manual/html_node/elisp/Face-Attributes.html
|
sounds resonable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#305 was a great but thin is too thin for fonts which support many
weights. This replaces thin by extra-light, which is still visibly
different from the normal weight but also still legible.
In fact, it's so thin, it's not even documented, see
https://github.com/emacs-mirror/emacs/blob/master/src/font.c#L71
https://www.gnu.org/software/emacs/manual/html_node/elisp/Face-Attributes.html
Screenshots (with Iosevka):
Note that these screenshots are upscaled 200% from hidpi screen, so legibility of thin was even worse in practice.