Fix #141 updating speaker names #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating from BBC repo
Updating from BBC
Updating from BBC master
…ad-only-mode Fix 133 speaker not editable in read only mode
bbc/react-transcript-editor@master...philmcmahon:update-all-speakers#diff-cdf6a9957d22ff2efacaaf5fb2876a8aR58 it works but does not seem to rerender after change
pietrop
changed the title
|
can change
|
emettely
suggested changes
Oct 9, 2019
There was a problem hiding this comment.
The feature is awesome, it's something that's definitely been fed back from our users as "would be extremely nice (actually necessary)" to have. I would like to get your thoughts across on the dialogue that pops up from the speaker name editing. There is an option missing imo - cancel.
Co-Authored-By: Eimi Okuno <[email protected]>
emettely
approved these changes
Oct 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is your Pull Request request related to another issue in this repository ?
#141
Describe what the PR does
Improves the experience of correcting speaker labels
State whether the PR is ready for review or whether it needs extra work
Ready for review
Additional context
Continuing with improvement on a separate PR #209