Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CIFuzz #1666

Closed
wants to merge 1 commit into from
Closed

Add CIFuzz #1666

wants to merge 1 commit into from

Conversation

AdamKorcz
Copy link

Adds CIFuzz. This will run the fuzzers during pull requests for 600 seconds. The time can be modified.

CIFuzz is an addition to ArduinoJson's OSS-fuzz integration. The documentation for CIFuzz can be found here: https://google.github.io/oss-fuzz/getting-started/continuous-integration/

The existing fuzzers are found here: https://github.com/bblanchon/ArduinoJson/tree/6.x/extras/fuzzing

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.463% when pulling c60ebda on AdamKorcz:fuzz1 into 5ed5f36 on bblanchon:6.x.

@bblanchon
Copy link
Owner

Thanks, @AdamKorcz; I didn't know about CIFuzz.
I'm already fuzzing the library as part of the CTest run, but CIFuzz seems to offer a cleaner solution, so I think I'll remove that.
Also, I think it makes sense to run CIFuzz after all builds succeeded and not in parallel.
Do you mind if I alter your PR before merging it?

@AdamKorcz
Copy link
Author

Do you mind if I alter your PR before merging it?

Not at all.

@bblanchon
Copy link
Owner

@AdamKorcz, I noticed you created the same PR in dozens of repositories; what's up with that?

@AdamKorcz
Copy link
Author

AdamKorcz commented Oct 28, 2021

@bblanchon I am a contributor to OSS-fuzz and fuzzing of open source software in general.

See list of OSS-fuzz contributors: https://github.com/google/oss-fuzz/graphs/contributors

See also https://adalogics.com/blog/fuzzing-100-open-source-projects-with-oss-fuzz for reference

@bblanchon
Copy link
Owner

Once you have completed an integration OSS-Fuzz offers an integration reward of 500-1000 USD. This is a nice reward for your work, and following the non-trivial effort of integrating your project it is of great pleasure to receive a monetary award.

Given that you created the same PR on the following repos, I'm wondering if you're only looking after the reward 😲

  1. Add CIFuzz libass/libass#568
  2. Add CIFuzz vitessio/vitess#9084
  3. Add CIFuzz libgit2/libgit2#6098
  4. Add CIFuzz libarchive/libarchive#1604
  5. Add CIFuzz libjpeg-turbo/libjpeg-turbo#559
  6. Add CIFuzz grpc-ecosystem/grpc-gateway#2405

Can you confirm that you will not receive any financial reward for these PRs?

@AdamKorcz AdamKorcz closed this Nov 3, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants