Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: display pretty stacktraces #467

Merged
merged 7 commits into from
Mar 22, 2020
Merged

Feat: display pretty stacktraces #467

merged 7 commits into from
Mar 22, 2020

Conversation

bcaudan
Copy link
Owner

@bcaudan bcaudan commented Mar 22, 2020

Goal

WIth option displayStacktrace: 'pretty', report stacktraces elements in context:

Capture d’écran 2020-03-22 à 15 54 42

Displayed colors are configurable from colors options:

colors: {
    ...
    prettyStacktraceFilename: "cyan",
    prettyStacktraceLineNumber: "yellow",
    prettyStacktraceColumnNumber: "yellow",
    prettyStacktraceError: "red",
}

Breaking changes

displayStacktrace options now take a value among none, raw and pretty.

@codecov
Copy link

codecov bot commented Mar 22, 2020

Codecov Report

Merging #467 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #467   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          14     16    +2     
  Lines         446    498   +52     
  Branches       61     69    +8     
=====================================
+ Hits          446    498   +52
Impacted Files Coverage Δ
src/display/colors-display.ts 100% <ø> (ø) ⬆️
src/processors/pretty-stacktrace-processor.ts 100% <100%> (ø)
src/spec-reporter.ts 100% <100%> (ø) ⬆️
src/configuration-parser.ts 100% <100%> (ø) ⬆️
src/main.ts 100% <100%> (ø) ⬆️
src/processors/default-processor.ts 100% <100%> (ø) ⬆️
src/configuration.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73d4174...ffa8ab4. Read the comment docs.

@bcaudan bcaudan merged commit a4a18b5 into master Mar 22, 2020
@bcaudan bcaudan deleted the pretty-errors branch March 22, 2020 15:27
holgiosalos added a commit to holgiosalos/workshop-protractor that referenced this pull request Jul 25, 2020
Updating spec reporter to include the new way to specify the `displayStacktrace` property

See: bcaudan/jasmine-spec-reporter#467
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant