GRAD2-3164: task is complete. #364
Conversation
GRAD2-3164: task is complete.
Fixed the broken junit test is fixed for PF validation.
More coverage & clean up comments.
Fixed the broken flows in Junit test.
| public String getSchoolName() { | ||
| return schoolName != null ? schoolName.trim(): null; | ||
| } |
There was a problem hiding this comment.
Removed all unnecessary methods.
| && ( StringUtils.isNotBlank(student.getSchoolOfRecord()) | ||
| && student.getSchoolOfRecord().startsWith("093") ) | ||
| ) { | ||
| && isSchoolForProgramFrancophone(student.getSchoolOfRecordId())) { |
There was a problem hiding this comment.
It is not supposed to have null schoolOfRecordId in GraduationStudentRecord. If so, that is critical, and intentionally good to have NPE instead of moving forward with the wrong grad program. Anyway, I will add the null check here, and monitor in PROD that schoolOfRecordId is null to have the wrong grad program in student load & ongoing updates.
| if (res != null) { | ||
| accessToken = res.getAccess_token(); | ||
| } | ||
| String accessToken = restUtils.fetchAccessToken(); |
There was a problem hiding this comment.
If we aren't changing now, do we have a ticket for removing access token from header for this api?
There was a problem hiding this comment.
A new client is required in keycloak to utilize client credential auth. I think a separate ticket to handle this is better.
Updated to improve after code review.
|
GRAD2-3164: task is complete.