Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CM-1005: Add autocomplete near a city field #1050

Merged
merged 26 commits into from
Nov 6, 2023
Merged

CM-1005: Add autocomplete near a city field #1050

merged 26 commits into from
Nov 6, 2023

Conversation

ayumi-oxd
Copy link
Collaborator

@ayumi-oxd ayumi-oxd commented Oct 16, 2023

Jira Ticket:

  • CM-1004
  • CM-1005
  • CM-1006
  • CM-1007
  • CM-1008
  • CM-1009
  • CM-1010
  • CM-1036
  • CM-1039

Description:

  • CM-1004: Update error page
  • CM-1005: Add autocomplete near a city field to find a park page
  • CM-1006: Add autocomplete near a city field to home page
  • CM-1007: Add end of results text to find a park page
  • CM-1008: Add current location functionality to near a city field
  • CM-1009: Update search results text on find a park page
  • CM-1010: Update search text field styling
  • CM-1036: Fix responsive layout issue on find a park page
  • CM-1039: Update by park name field

Known Issues:

  • Searching from the Home page, the search result is correct but the park name field do not change

@ayumi-oxd ayumi-oxd force-pushed the CM-1004 branch 2 times, most recently from e4149cd to ec28a2d Compare October 18, 2023 17:17
@ayumi-oxd ayumi-oxd changed the title WIP⚠️CM-1004: Update error message for no search result WIP⚠️CM-1005: Add autocomplete near a city field Oct 18, 2023
@ayumi-oxd ayumi-oxd marked this pull request as ready for review October 31, 2023 16:38
@ayumi-oxd ayumi-oxd requested a review from molund October 31, 2023 16:39
@ayumi-oxd ayumi-oxd changed the title WIP⚠️CM-1005: Add autocomplete near a city field CM-1005: Add autocomplete near a city field Oct 31, 2023
@molund
Copy link
Collaborator

molund commented Nov 1, 2023

The bookmarkable URLs don't seem to be working correctly.

If I navigate to the same URL in a new browser window, then all the same selections should be made by default.

e.g. I selected Coquitlam and entered the search term "park" and this was the URL
http://localhost:8000/find-a-park/?l=49.2837626%2C-122.7932065&q=park

It should select Coquitlam by default, but instead "Current location" is selected and the search term is missing

@ayumi-oxd ayumi-oxd merged commit 025ef43 into develop Nov 6, 2023
2 checks passed
@ayumi-oxd ayumi-oxd deleted the CM-1004 branch November 6, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants