Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMS-363: Update snowplow tracking #1503

Merged
merged 1 commit into from
Oct 25, 2024
Merged

CMS-363: Update snowplow tracking #1503

merged 1 commit into from
Oct 25, 2024

Conversation

ayumi-oxd
Copy link
Collaborator

Jira Ticket:

CMS-363

Description:

  • Update snowplow tracking

@ayumi-oxd ayumi-oxd marked this pull request as ready for review October 25, 2024 00:01
@ayumi-oxd ayumi-oxd requested a review from duncan-oxd October 25, 2024 00:01
@ayumi-oxd ayumi-oxd merged commit 225a686 into alpha Oct 25, 2024
4 checks passed
@ayumi-oxd ayumi-oxd deleted the CMS-363 branch October 25, 2024 16:52
@molund
Copy link
Collaborator

molund commented Oct 25, 2024

The idea behind this ticket was actually to call the snowplow event every time a page renders or re-renders, not just when the router is updated. For example if you use the pagination control at the bottom of the active advisories page the url doesn't change but new content is added to the page which is not hooked up to any snowplow events

@duncan-oxd
Copy link
Collaborator

Ah... Hopefully it's as simple as adding tracking call to a few more event hooks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants