Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMS-545: Add retry to fetch advisories on park operating dates page #1546

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

ayumi-oxd
Copy link
Collaborator

Jira Ticket:

CMS-545

Description:

@ayumi-oxd ayumi-oxd marked this pull request as ready for review December 9, 2024 23:42
@ayumi-oxd ayumi-oxd requested a review from duncan-oxd December 9, 2024 23:42
@ayumi-oxd ayumi-oxd added v.2.8.x help wanted Extra attention is needed labels Dec 9, 2024
@duncan-oxd
Copy link
Collaborator

I get errors intermittently from Strapi on the dev environment when I'm trying to build the site. It doesn't print out the error code but I bet they're also 429 "Too many requests"

Let's ask around and see if we can have the request limit raised a bit on these environments so we won't get the error anymore. Or at least not as often!

@duncan-oxd duncan-oxd changed the title CMS-545: Add retry to fecth advisories on park operating dates page CMS-545: Add retry to fetch advisories on park operating dates page Dec 10, 2024
Copy link
Collaborator

@duncan-oxd duncan-oxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed on slack, the real fix for this will come from the Strapi server config, but this incremental backoff could still be useful if you want to merge it 👍

@ayumi-oxd ayumi-oxd merged commit cdc45a0 into alpha Dec 10, 2024
4 checks passed
@ayumi-oxd ayumi-oxd deleted the CMS-545 branch December 10, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed v.2.8.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants