Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMS-484: Accessibility updates #1554

Draft
wants to merge 20 commits into
base: alpha
Choose a base branch
from
Draft

CMS-484: Accessibility updates #1554

wants to merge 20 commits into from

Conversation

ayumi-oxd
Copy link
Collaborator

@ayumi-oxd ayumi-oxd commented Dec 17, 2024 •
edited
Loading

Jira Ticket:

CMS-484
CMS-485
CMS-488
CMS-489
CMS-490
CMS-492
CMS-494
CMS-496
CMS-498
CMS-500
CMS-533
CMS-536
CMS-540
CMS-542
CMS-550
CMS-551
CMS-553
CMS-554
CMS-570

Description:

  • CMS-484, 485: Contain an element with role=menuitem in an element with role=menu
    • Adding role to ul and li caused a warning: "Non-interactive elements should not be assigned interactive roles jsx-a11y/no-noninteractive-element-to-interactive-role" so changed these elements to div
  • CMS-488, CMS-494: Remove role=button from park photo gallery
    • Remove roll=button from div
    • Change the element around the image to button so that users can click/tab focus on each image
  • CMS-489: Add aria-controls to input
    • Add aria-control to the park name search and the city name search input field
    • Add aria-control to the filter checkbox input fields
  • CMS-490, 533: Add for to advisories search filter label
  • CMS-492: Add underline to links under the more ways to find a park
  • CMS-496: Add title to iframe
    • Remove HTMLArea file and replace it with HtmlContent since it was a duplicate
  • CMS-498: Apply aria-label to see all link on find a park page
  • CMS-500: Add lang attribute to htmlContent
    • lang="en" is already set at <html> but add it again to htmlContent to ensure
  • CMS-536: Add unique id to popular filters on find a park page
  • CMS-540: Move focus when the scroll button is clicked by keyboard
    • Move focus to the last card item when the load more button is clicked by keyboard on the Active advisories page
  • CMS-542: Add urgency level name to advisory icon
    • Update aria-label based on urgency level
  • CMS-550: Change heading on find a park page
    • Change h3 to p since the page doesn't have h1 and h2
  • CMS-551: Remove alt from fontawesome icon
  • CMS-553: Add aria label to show all links and expand all links
    • Update show all links and expand all links name
  • CMS-554: Add aria live to no match message in typeahead fields
  • CMS-570: Change aria label on go back to the full list button
  • Remove unused component files

@ayumi-oxd ayumi-oxd force-pushed the accessibility-updates branch from b212d70 to 6a686f5 Compare December 24, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
v.2.9.x WIP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ayumi-oxd