CMS-545: Update api fetching on park operating dates page #1560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncan-oxd
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
Batching requests whenever possible is a good idea! We might still want to change the rate limit on the dev environment, because I often have trouble even building the site with the Dev Strapi because of how many calls it does. But this looks like a big improvement for the public site 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket:
CMS-545
Description:
After talking to @fatbird we've decided to change the API call rather than changing the API rate limit:
protectedArea.orcso that we can determine each park access status