Test Updates/Fixes (#620)

Test updates/Fixes
bcgov · Oct 29, 2021 · 85245b8 · 85245b8
1 parent db15ba7
commit 85245b8
Show file tree

Hide file tree

Showing 66 changed files with 879 additions and 913 deletions.
diff --git a/api/src/database/db.test.ts b/api/src/database/db.test.ts
@@ -3,6 +3,7 @@ import { describe } from 'mocha';
 import * as pg from 'pg';
 import Sinon from 'sinon';
 import { SYSTEM_IDENTITY_SOURCE } from '../constants/database';
+import { CustomError } from '../errors/CustomError';
 import { setSystemUserContextSQL } from '../queries/user-context-queries';
 import * as db from './db';
 import { getAPIUserDBConnection, getDBConnection, getDBPool, IDBConnection, initDBPool } from './db';
@@ -36,7 +37,7 @@ describe('db', () => {
 
         expect.fail();
       } catch (actualError) {
-        expect(actualError.message).to.equal('Keycloak token is undefined');
+        expect((actualError as CustomError).message).to.equal('Keycloak token is undefined');
       }
     });
 

diff --git a/api/src/paths/access-request.test.ts b/api/src/paths/access-request.test.ts
@@ -7,6 +7,7 @@ import * as user_queries from '../queries/users/user-queries';
 import * as db from '../database/db';
 import SQL from 'sql-template-strings';
 import { getMockDBConnection } from '../__mocks__/db';
+import { CustomError } from '../errors/CustomError';
 
 chai.use(sinonChai);
 
@@ -38,8 +39,8 @@ describe('updateAccessRequest', () => {
       );
       expect.fail();
     } catch (actualError) {
-      expect(actualError.status).to.equal(400);
-      expect(actualError.message).to.equal('Missing required body param: userIdentifier');
+      expect((actualError as CustomError).status).to.equal(400);
+      expect((actualError as CustomError).message).to.equal('Missing required body param: userIdentifier');
     }
   });
 
@@ -54,8 +55,8 @@ describe('updateAccessRequest', () => {
       );
       expect.fail();
     } catch (actualError) {
-      expect(actualError.status).to.equal(400);
-      expect(actualError.message).to.equal('Missing required body param: identitySource');
+      expect((actualError as CustomError).status).to.equal(400);
+      expect((actualError as CustomError).message).to.equal('Missing required body param: identitySource');
     }
   });
 
@@ -70,8 +71,8 @@ describe('updateAccessRequest', () => {
       );
       expect.fail();
     } catch (actualError) {
-      expect(actualError.status).to.equal(400);
-      expect(actualError.message).to.equal('Missing required body param: requestId');
+      expect((actualError as CustomError).status).to.equal(400);
+      expect((actualError as CustomError).message).to.equal('Missing required body param: requestId');
     }
   });
 
@@ -86,8 +87,8 @@ describe('updateAccessRequest', () => {
       );
       expect.fail();
     } catch (actualError) {
-      expect(actualError.status).to.equal(400);
-      expect(actualError.message).to.equal('Missing required body param: requestStatusTypeId');
+      expect((actualError as CustomError).status).to.equal(400);
+      expect((actualError as CustomError).message).to.equal('Missing required body param: requestStatusTypeId');
     }
   });
 
@@ -106,8 +107,8 @@ describe('updateAccessRequest', () => {
       await result(sampleReq, (null as unknown) as any, (null as unknown) as any);
       expect.fail();
     } catch (actualError) {
-      expect(actualError.status).to.equal(400);
-      expect(actualError.message).to.equal('Failed to build SQL get statement');
+      expect((actualError as CustomError).status).to.equal(400);
+      expect((actualError as CustomError).message).to.equal('Failed to build SQL get statement');
     }
   });
 
@@ -134,8 +135,8 @@ describe('updateAccessRequest', () => {
       await result(sampleReq, (null as unknown) as any, (null as unknown) as any);
       expect.fail();
     } catch (actualError) {
-      expect(actualError.status).to.equal(400);
-      expect(actualError.message).to.equal('Failed to identify system user ID');
+      expect((actualError as CustomError).status).to.equal(400);
+      expect((actualError as CustomError).message).to.equal('Failed to identify system user ID');
     }
   });
 
@@ -169,8 +170,8 @@ describe('updateAccessRequest', () => {
       await result(sampleReq, (null as unknown) as any, (null as unknown) as any);
       expect.fail();
     } catch (actualError) {
-      expect(actualError.status).to.equal(500);
-      expect(actualError.message).to.equal('Failed to get or add system user');
+      expect((actualError as CustomError).status).to.equal(500);
+      expect((actualError as CustomError).message).to.equal('Failed to get or add system user');
     }
   });
 });
diff --git a/api/src/paths/administrative-activities.test.ts b/api/src/paths/administrative-activities.test.ts
@@ -7,6 +7,7 @@ import * as administrative_queries from '../queries/administrative-activity/admi
 import * as db from '../database/db';
 import { getMockDBConnection } from '../__mocks__/db';
 import SQL from 'sql-template-strings';
+import { CustomError } from '../errors/CustomError';
 
 chai.use(sinonChai);
 
@@ -47,8 +48,8 @@ describe('getAdministrativeActivities', () => {
       await result(sampleReq, (null as unknown) as any, (null as unknown) as any);
       expect.fail();
     } catch (actualError) {
-      expect(actualError.status).to.equal(400);
-      expect(actualError.message).to.equal('Failed to build SQL get statement');
+      expect((actualError as CustomError).status).to.equal(400);
+      expect((actualError as CustomError).message).to.equal('Failed to build SQL get statement');
     }
   });
 

diff --git a/api/src/paths/administrative-activity.test.ts b/api/src/paths/administrative-activity.test.ts
@@ -8,6 +8,7 @@ import * as db from '../database/db';
 import { getMockDBConnection } from '../__mocks__/db';
 import SQL from 'sql-template-strings';
 import * as keycloak_utils from '../utils/keycloak-utils';
+import { CustomError } from '../errors/CustomError';
 
 chai.use(sinonChai);
 
@@ -48,8 +49,8 @@ describe('updateAccessRequest', () => {
       await result(sampleReq, (null as unknown) as any, (null as unknown) as any);
       expect.fail();
     } catch (actualError) {
-      expect(actualError.status).to.equal(500);
-      expect(actualError.message).to.equal('Failed to identify system user ID');
+      expect((actualError as CustomError).status).to.equal(500);
+      expect((actualError as CustomError).message).to.equal('Failed to identify system user ID');
     }
   });
 
@@ -68,8 +69,8 @@ describe('updateAccessRequest', () => {
       await result(sampleReq, (null as unknown) as any, (null as unknown) as any);
       expect.fail();
     } catch (actualError) {
-      expect(actualError.status).to.equal(500);
-      expect(actualError.message).to.equal('Failed to build SQL insert statement');
+      expect((actualError as CustomError).status).to.equal(500);
+      expect((actualError as CustomError).message).to.equal('Failed to build SQL insert statement');
     }
   });
 
@@ -95,8 +96,8 @@ describe('updateAccessRequest', () => {
       await result(sampleReq, (null as unknown) as any, (null as unknown) as any);
       expect.fail();
     } catch (actualError) {
-      expect(actualError.status).to.equal(500);
-      expect(actualError.message).to.equal('Failed to submit administrative activity');
+      expect((actualError as CustomError).status).to.equal(500);
+      expect((actualError as CustomError).message).to.equal('Failed to submit administrative activity');
     }
   });
 
@@ -127,8 +128,8 @@ describe('updateAccessRequest', () => {
       await result(sampleReq, (null as unknown) as any, (null as unknown) as any);
       expect.fail();
     } catch (actualError) {
-      expect(actualError.status).to.equal(500);
-      expect(actualError.message).to.equal('Failed to submit administrative activity');
+      expect((actualError as CustomError).status).to.equal(500);
+      expect((actualError as CustomError).message).to.equal('Failed to submit administrative activity');
     }
   });
 
@@ -196,8 +197,8 @@ describe('getPendingAccessRequestsCount', () => {
       await result(sampleReq, (null as unknown) as any, (null as unknown) as any);
       expect.fail();
     } catch (actualError) {
-      expect(actualError.status).to.equal(400);
-      expect(actualError.message).to.equal('Missing required userIdentifier');
+      expect((actualError as CustomError).status).to.equal(400);
+      expect((actualError as CustomError).message).to.equal('Missing required userIdentifier');
     }
   });
 
@@ -217,8 +218,8 @@ describe('getPendingAccessRequestsCount', () => {
       await result(sampleReq, (null as unknown) as any, (null as unknown) as any);
       expect.fail();
     } catch (actualError) {
-      expect(actualError.status).to.equal(400);
-      expect(actualError.message).to.equal('Failed to build SQL get statement');
+      expect((actualError as CustomError).status).to.equal(400);
+      expect((actualError as CustomError).message).to.equal('Failed to build SQL get statement');
     }
   });
 
@@ -293,8 +294,8 @@ describe('getUpdateAdministrativeActivityHandler', () => {
       await result(sampleReq, (null as unknown) as any, (null as unknown) as any);
       expect.fail();
     } catch (actualError) {
-      expect(actualError.status).to.equal(400);
-      expect(actualError.message).to.equal('Missing required body parameter: id');
+      expect((actualError as CustomError).status).to.equal(400);
+      expect((actualError as CustomError).message).to.equal('Missing required body parameter: id');
     }
   });
 
@@ -309,8 +310,8 @@ describe('getUpdateAdministrativeActivityHandler', () => {
       );
       expect.fail();
     } catch (actualError) {
-      expect(actualError.status).to.equal(400);
-      expect(actualError.message).to.equal('Missing required body parameter: status');
+      expect((actualError as CustomError).status).to.equal(400);
+      expect((actualError as CustomError).message).to.equal('Missing required body parameter: status');
     }
   });
 });
@@ -335,8 +336,8 @@ describe('updateAdministrativeActivity', () => {
 
       expect.fail();
     } catch (actualError) {
-      expect(actualError.status).to.equal(400);
-      expect(actualError.message).to.equal('Failed to build SQL put statement');
+      expect((actualError as CustomError).status).to.equal(400);
+      expect((actualError as CustomError).message).to.equal('Failed to build SQL put statement');
     }
   });
 
@@ -360,8 +361,8 @@ describe('updateAdministrativeActivity', () => {
 
       expect.fail();
     } catch (actualError) {
-      expect(actualError.status).to.equal(500);
-      expect(actualError.message).to.equal('Failed to update administrative activity');
+      expect((actualError as CustomError).status).to.equal(500);
+      expect((actualError as CustomError).message).to.equal('Failed to update administrative activity');
     }
   });
 });
diff --git a/api/src/paths/codes.test.ts b/api/src/paths/codes.test.ts
@@ -6,6 +6,7 @@ import * as codes from './codes';
 import * as db from '../database/db';
 import * as code_utils from '../utils/code-utils';
 import { getMockDBConnection } from '../__mocks__/db';
+import { CustomError } from '../errors/CustomError';
 
 chai.use(sinonChai);
 
@@ -45,8 +46,8 @@ describe('codes', () => {
         await result(sampleReq, (null as unknown) as any, (null as unknown) as any);
         expect.fail();
       } catch (actualError) {
-        expect(actualError.status).to.equal(500);
-        expect(actualError.message).to.equal('Failed to fetch codes');
+        expect((actualError as CustomError).status).to.equal(500);
+        expect((actualError as CustomError).message).to.equal('Failed to fetch codes');
       }
     });
 
@@ -75,7 +76,7 @@ describe('codes', () => {
         await result(sampleReq, sampleRes as any, (null as unknown) as any);
         expect.fail();
       } catch (actualError) {
-        expect(actualError.message).to.equal(expectedError.message);
+        expect((actualError as CustomError).message).to.equal(expectedError.message);
       }
     });
   });