code smells

bcgov · Apr 19, 2022 · c6c0e35 · c6c0e35
1 parent 19f9a2c
commit c6c0e35
Showing 1 changed file with 4 additions and 12 deletions.
diff --git a/api/src/queries/users/user-queries.ts b/api/src/queries/users/user-queries.ts
@@ -147,7 +147,7 @@ export const deactivateSystemUserSQL = (userId: number): SQLStatement | null =>
     return null;
   }
 
-  const sqlStatement = SQL`
+  return SQL`
     UPDATE
       system_user
     SET
@@ -157,8 +157,6 @@ export const deactivateSystemUserSQL = (userId: number): SQLStatement | null =>
     RETURNING
       *;
   `;
-
-  return sqlStatement;
 };
 
 /**
@@ -172,7 +170,7 @@ export const activateSystemUserSQL = (userId: number): SQLStatement | null => {
     return null;
   }
 
-  const sqlStatement = SQL`
+  return SQL`
     UPDATE
       system_user
     SET
@@ -182,8 +180,6 @@ export const activateSystemUserSQL = (userId: number): SQLStatement | null => {
     RETURNING
       *;
   `;
-
-  return sqlStatement;
 };
 
 /**
@@ -198,16 +194,14 @@ export const deleteAllSystemRolesSQL = (userId: number): SQLStatement | null =>
     return null;
   }
 
-  const sqlStatement = SQL`
+  return SQL`
     DELETE FROM
       system_user_role
     WHERE
       system_user_id = ${userId}
     RETURNING
       *;
   `;
-
-  return sqlStatement;
 };
 
 /**
@@ -222,14 +216,12 @@ export const deleteAllProjectRolesSQL = (userId: number): SQLStatement | null =>
     return null;
   }
 
-  const sqlStatement = SQL`
+  return SQL`
     DELETE FROM
       project_participation
     WHERE
       system_user_id = ${userId}
     RETURNING
       *;
   `;
-
-  return sqlStatement;
 };