Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BHBC-2306: Hide Submit functionality #1001

Merged
merged 7 commits into from
Apr 14, 2023
Merged

BHBC-2306: Hide Submit functionality #1001

merged 7 commits into from
Apr 14, 2023

Conversation

AlfredRosenthal
Copy link
Contributor

@AlfredRosenthal AlfredRosenthal commented Apr 13, 2023

Overview

Links to Jira tickets

BHBC-2306

Description of relevant changes

  • Added System Role Guard to various status columns and submission buttons
  • Added TODO: PRODUCTION_BANDAGE to the pages to mark what changes to be removed later

Testing Steps

  • Login as a Data/ System admin
  • Create a project and survey
  • Add documents/ observations to the Survey and see submit buttons and status on documents
  • Add documents to project and see submission status and submit button
  • Modify current permissions to be a Creator (this will throw an error but can be ignored for now. Issue tracked in BHBC-2309
  • Step through newly created project/ survey, all status and submission information will now be hidden

PR Checklist

A list of items that are good to consider when making any changes.

Note: this list is not exhaustive, and not all items are always applicable.

Code

  • New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
  • I have avoided duplicating code when possible, moving re-usable pieces into functions
  • I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
  • My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
  • My code changes account for null/undefined values and handle errors appropriately
  • My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

  • My code follows the established style conventions
  • My code uses native material-ui components/icons/conventions when possible

Documentation

  • I have commented my code sufficiently, such that an unfamiliar developer could understand my code
  • I have added/updated README's and related documentation, as needed

Tests

  • I have added/updated unit tests for any code I've added/updated
  • I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

  • I have run the linter and fixed any issues, as needed
    See the lint commands in package.json
  • I have run the formatter and fixed any issues, as needed
    See the format commands in package.json

SonarCloud

  • I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Merging #1001 (32f814f) into dev (eb001b6) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev    #1001      +/-   ##
==========================================
- Coverage   68.12%   68.06%   -0.06%     
==========================================
  Files         378      378              
  Lines       11730    11730              
  Branches     1990     1990              
==========================================
- Hits         7991     7984       -7     
- Misses       3290     3298       +8     
+ Partials      449      448       -1     
Impacted Files Coverage Δ
...rc/components/attachments/list/AttachmentsList.tsx 80.95% <ø> (ø)
...pp/src/features/projects/list/ProjectsListPage.tsx 66.66% <ø> (ø)
app/src/features/surveys/view/SurveyPage.tsx 12.50% <ø> (ø)
.../summary-results/components/FileSummaryResults.tsx 7.40% <ø> (ø)
...ey-observations/components/ObservationFileCard.tsx 34.61% <ø> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AlfredRosenthal AlfredRosenthal marked this pull request as ready for review April 13, 2023 18:17
@curtisupshall curtisupshall self-assigned this Apr 13, 2023
Copy link
Contributor

@curtisupshall curtisupshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected!

@curtisupshall
Copy link
Contributor

curtisupshall commented Apr 13, 2023

If this PR started as a draft, you need to make a commit with "ignore-skip" in the message:

git commit --allow-empty -m "ignore-skip"

Copy link
Contributor

@KjartanE KjartanE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😹

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@AlfredRosenthal AlfredRosenthal merged commit e48eac6 into dev Apr 14, 2023
@AlfredRosenthal AlfredRosenthal deleted the BHBC-2306 branch April 14, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants