Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BHBC-2215: Update Project Role permissions for API #1003

Merged
merged 12 commits into from
Apr 17, 2023
Merged

Conversation

AlfredRosenthal
Copy link
Contributor

@AlfredRosenthal AlfredRosenthal commented Apr 14, 2023

Overview

Links to Jira tickets

BHBC-2215

Description of relevant changes

  • updated view occurrences endpoint to properly check authorization rules
  • updated various endpoints to keep inline with current role rules (found in confluence SIMS>Roles & Permissions)

Testing Procedure

Viewer Case

  • Create a project/ survey as an admin
  • Invite a participant with the viewer role
  • Login as that newly invited user
  • Interact with the project/ survey
  • attempt to save or modify metadata, attachments and be met with errors / access denied messages

Editor Case

  • Create a project/ survey as an admin
  • Invite a participant with the editor role
  • Login as the newly invited user
  • Interact with the project/ survey
  • The editor should be able to edit metadata, upload/ delete attachments and even delete the survey itself

PR Checklist

A list of items that are good to consider when making any changes.

Note: this list is not exhaustive, and not all items are always applicable.

Code

  • New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
  • I have avoided duplicating code when possible, moving re-usable pieces into functions
  • I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
  • My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
  • My code changes account for null/undefined values and handle errors appropriately
  • My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

  • My code follows the established style conventions
  • My code uses native material-ui components/icons/conventions when possible

Documentation

  • I have commented my code sufficiently, such that an unfamiliar developer could understand my code
  • I have added/updated README's and related documentation, as needed

Tests

  • I have added/updated unit tests for any code I've added/updated
  • I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

  • I have run the linter and fixed any issues, as needed
    See the lint commands in package.json
  • I have run the formatter and fixed any issues, as needed
    See the format commands in package.json

SonarCloud

  • I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Merging #1003 (7746e56) into dev (2100bc5) will not change coverage.
The diff coverage is 40.00%.

@@           Coverage Diff           @@
##              dev    #1003   +/-   ##
=======================================
  Coverage   68.06%   68.06%           
=======================================
  Files         378      378           
  Lines       11730    11730           
  Branches     1990     1990           
=======================================
  Hits         7984     7984           
  Misses       3298     3298           
  Partials      448      448           
Impacted Files Coverage Δ
api/src/paths/dwc/view-occurrences.ts 96.42% <ø> (ø)
...hs/project/{projectId}/survey/{surveyId}/delete.ts 94.59% <ø> (ø)
api/src/paths/publish/project.ts 0.00% <ø> (ø)
api/src/paths/publish/survey.ts 95.65% <ø> (ø)
app/src/components/map/OccurrenceFeatureGroup.tsx 0.00% <0.00%> (ø)
...atures/surveys/view/components/SurveyStudyArea.tsx 55.55% <33.33%> (ø)
app/src/hooks/api/useObservationApi.ts 87.09% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@curtisupshall curtisupshall self-assigned this Apr 14, 2023
KjartanE
KjartanE previously approved these changes Apr 14, 2023
Copy link
Contributor

@KjartanE KjartanE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐱

@AlfredRosenthal AlfredRosenthal marked this pull request as ready for review April 14, 2023 23:42
@curtisupshall curtisupshall self-requested a review April 17, 2023 18:40
@curtisupshall curtisupshall requested a review from KjartanE April 17, 2023 19:51
KjartanE
KjartanE previously approved these changes Apr 17, 2023
Copy link
Contributor

@KjartanE KjartanE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😸

app/src/features/surveys/view/SurveyHeader.tsx Outdated Show resolved Hide resolved
app/src/hooks/api/useProjectApi.ts Outdated Show resolved Hide resolved
@curtisupshall curtisupshall requested a review from KjartanE April 17, 2023 22:42
NickPhura
NickPhura previously approved these changes Apr 17, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@curtisupshall curtisupshall requested a review from NickPhura April 17, 2023 23:20
@curtisupshall curtisupshall merged commit 0850ab6 into dev Apr 17, 2023
@curtisupshall curtisupshall deleted the BHBC-2215 branch April 17, 2023 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants