Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BHBC-2301: Limit Map tab view to data and system admins only #1006

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

curtisupshall
Copy link
Contributor

@curtisupshall curtisupshall commented Apr 17, 2023

Overview

The Map page is now only visible to Data Admin and System Admin

Links to Jira tickets

Testing Procedure

  1. Sign into SIMS as a Data Administrator. You should:
  • See the Map tab in the header.
  1. Right-click on the Map link and click Copy link address (see Step 5)

  2. Switch your role to System Admin and reload the app. You should:

  • See the Map tab in the header.
  1. Switch your role to Creator and reload the app. You should:
  • NOT see the Map tab in the header.
  1. Paste the link you copied from earlier. Alternatively, navigate to /admin/search. You should
  • See the Forbidden page

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Merging #1006 (e102c62) into dev (e48eac6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #1006   +/-   ##
=======================================
  Coverage   68.06%   68.06%           
=======================================
  Files         378      378           
  Lines       11730    11730           
  Branches     1990     1990           
=======================================
  Hits         7984     7984           
  Misses       3298     3298           
  Partials      448      448           
Impacted Files Coverage Δ
app/src/components/layout/Header.tsx 85.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@KjartanE KjartanE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐈

@curtisupshall curtisupshall merged commit 2100bc5 into dev Apr 17, 2023
@NickPhura NickPhura deleted the BHBC-2301 branch April 26, 2023 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants