BHBC-2303: UI/UX Assurance Pass Over Interfaces for Submitting Data

[jeznorth]

Overview

Links to Jira tickets

• https://quartech.atlassian.net/browse/BHBC-2303

Description of relevant changes

• General UI fixes / improvements / enhancements

PR Checklist

A list of items that are good to consider when making any changes.

Note: this list is not exhaustive, and not all items are always applicable.

Code

• New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
• I have avoided duplicating code when possible, moving re-usable pieces into functions
• I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
• My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
• My code changes account for null/undefined values and handle errors appropriately
• My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

• My code follows the established style conventions
• My code uses native material-ui components/icons/conventions when possible

Documentation

• I have commented my code sufficiently, such that an unfamiliar developer could understand my code
• I have added/updated README's and related documentation, as needed

Tests

• I have added/updated unit tests for any code I've added/updated
• I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

• I have run the linter and fixed any issues, as needed
  See the lint commands in package.json
• I have run the formatter and fixed any issues, as needed
  See the format commands in package.json

SonarCloud

• I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

[github-actions]

Openshift URLs for the PR Deployment:

• App Route: https://biohubbc-app-1009-af2668-dev.apps.silver.devops.gov.bc.ca/
• Api Route: https://biohubbc-api-1009-af2668-dev.apps.silver.devops.gov.bc.ca/
• Pods: https://console.apps.silver.devops.gov.bc.ca/k8s/ns/af2668-dev/pods?name=1009

[codecov]

Codecov Report

Merging #1009 (85e4df8) into dev (d59e001) will decrease coverage by 0.02%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##              dev    #1009      +/-   ##
==========================================
- Coverage   68.15%   68.14%   -0.02%     
==========================================
  Files         384      384              
  Lines       11895    11897       +2     
  Branches     2030     2030              
==========================================
  Hits         8107     8107              
- Misses       3326     3328       +2     
  Partials      462      462              

Impacted Files	Coverage Δ
...attachments/list/AttachmentsListItemMenuButton.tsx	66.66% <ø> (ø)
app/src/components/layout/Header.tsx	85.00% <ø> (ø)
...mponents/publish/ProjectListSubmissionAlertBar.tsx	33.33% <0.00%> (-1.67%)	⬇️
...c/components/publish/ProjectSubmissionAlertBar.tsx	3.33% <0.00%> (-0.12%)	⬇️
...pp/src/components/publish/PublishProjectButton.tsx	9.67% <ø> (ø)
.../src/components/publish/PublishProjectSections.tsx	33.33% <ø> (ø)
app/src/components/surveys/SurveysList.tsx	85.00% <ø> (ø)
app/src/components/toolbar/ActionToolbars.tsx	75.00% <ø> (ø)
...ures/projects/view/components/LocationBoundary.tsx	4.47% <ø> (ø)
app/src/features/surveys/list/SurveysListPage.tsx	77.77% <ø> (ø)
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[sonarqubecloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
17.4% Duplication

[AlfredRosenthal]

🌻