-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SIMSBIOHUB-30: SIMS Home Page #1020
Conversation
Openshift URLs for the PR Deployment: |
Codecov Report
@@ Coverage Diff @@
## dev #1020 +/- ##
==========================================
+ Coverage 68.34% 68.46% +0.11%
==========================================
Files 383 384 +1
Lines 11930 11968 +38
Branches 2031 2040 +9
==========================================
+ Hits 8154 8194 +40
+ Misses 3301 3300 -1
+ Partials 475 474 -1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 😸
@curtisupshall: On the access denied page, now that we no longer have application wide authentication, we should change the message to say "You do not have permission to access this page." (rather than sometimes saying "application"). |
…o SIMSBIOHUB-30
…o SIMSBIOHUB-30
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👪
Tried it out locally, looks good!
Overview
Creates the publicly-accessible home page in SIMS.
Links to Jira tickets
Description of relevant changes
/admin/resources
to just/resources
;/login
helper endpoint, which sends the user to the Keycloak instance;Testing Procedure