Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-30: SIMS Home Page #1020

Merged
merged 62 commits into from
May 9, 2023
Merged

SIMSBIOHUB-30: SIMS Home Page #1020

merged 62 commits into from
May 9, 2023

Conversation

curtisupshall
Copy link
Contributor

@curtisupshall curtisupshall commented Apr 27, 2023

Overview

Creates the publicly-accessible home page in SIMS.

Links to Jira tickets

Description of relevant changes

  • Moved Resources page from /admin/resources to just /resources;
  • Added utility functions for building generic URLs and for generating the Login Page URL (historically, we have programatically sent the user to the Keycloak instance);
  • Added a /login helper endpoint, which sends the user to the Keycloak instance;
  • When unauthenticated access the SIMS application they land on a home page (historically, they are redirected to the Keycloak instance);
  • Added repo and service classes for Administrative Activities
  • Created the SIMS Landing Page

Testing Procedure

  1. Access the application having not signed in. You should:
  • See the SIMS Home page.
  1. Click Resources in the header. You should:
  • Be able to access the Resources page.
  1. Click the BioHub logo in the header. You should:
  • Arrive back on the Home page.
  1. Click the Log In. You should:
  • Be taken to the Keycloak instance.
  1. Proceed to log in to SIMS as an administrator. You should:
  • Be redirected to the Projects page.
  1. Click the BioHub logo in the header. You should:
  • Have the app root as your browser URL location
  • Arrive back on the Home page;
  • See the message Welcome back, <USERNAME>;
  • See the View Projects button;
  • See the Manage Users button;
  1. Change your role to a non-administrator, or sign into SIMS as a non-administrator.
  2. Navigate back to the home screen. You should:
  • See the message Welcome back, <USERNAME>;
  • See the View Projects button;
  • See the Create a Project button;
  1. Log out of the application. You should:
  • Be redirected to the Home page;

@curtisupshall curtisupshall added the Early Feedback Welcome PR is not finished, but early review feedback is welcomed label Apr 27, 2023
@curtisupshall curtisupshall requested a review from jeznorth April 27, 2023 21:44
@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Merging #1020 (20959ec) into dev (7c8e44a) will increase coverage by 0.11%.
The diff coverage is 88.96%.

@@            Coverage Diff             @@
##              dev    #1020      +/-   ##
==========================================
+ Coverage   68.34%   68.46%   +0.11%     
==========================================
  Files         383      384       +1     
  Lines       11930    11968      +38     
  Branches     2031     2040       +9     
==========================================
+ Hits         8154     8194      +40     
+ Misses       3301     3300       -1     
+ Partials      475      474       -1     
Impacted Files Coverage Δ
api/src/queries/queries.ts 100.00% <ø> (ø)
app/src/pages/200/RequestSubmitted.tsx 100.00% <ø> (ø)
app/src/pages/403/AccessDenied.tsx 75.00% <ø> (-1.93%) ⬇️
app/src/pages/authentication/LogOutPage.tsx 100.00% <ø> (ø)
app/src/pages/authentication/LoginPage.tsx 0.00% <0.00%> (ø)
app/src/test-helpers/auth-helpers.ts 54.54% <28.57%> (-1.02%) ⬇️
app/src/hooks/useKeycloakWrapper.tsx 73.68% <62.50%> (+2.25%) ⬆️
...repositories/administrative-activity-repository.ts 92.50% <92.50%> (ø)
api/src/paths/administrative-activity.ts 88.37% <92.85%> (-5.84%) ⬇️
api/src/constants/administrative-activity.ts 100.00% <100.00%> (ø)
... and 11 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@curtisupshall curtisupshall removed the Early Feedback Welcome PR is not finished, but early review feedback is welcomed label Apr 27, 2023
@curtisupshall curtisupshall added the Early Feedback Welcome PR is not finished, but early review feedback is welcomed label Apr 27, 2023
@curtisupshall curtisupshall removed the Early Feedback Welcome PR is not finished, but early review feedback is welcomed label Apr 27, 2023
KjartanE
KjartanE previously approved these changes Apr 27, 2023
Copy link
Contributor

@KjartanE KjartanE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 😸

@KjartanE KjartanE self-assigned this Apr 27, 2023
@NickPhura NickPhura added the Do Not Merge PR should not be merged label Apr 28, 2023
app/src/AppRouter.tsx Outdated Show resolved Hide resolved
@curtisupshall curtisupshall removed the Do Not Merge PR should not be merged label Apr 28, 2023
@NickPhura
Copy link
Collaborator

@curtisupshall: On the access denied page, now that we no longer have application wide authentication, we should change the message to say "You do not have permission to access this page." (rather than sometimes saying "application").

jeznorth
jeznorth previously approved these changes May 8, 2023
NickPhura
NickPhura previously approved these changes May 8, 2023
jeznorth
jeznorth previously approved these changes May 8, 2023
@curtisupshall curtisupshall dismissed stale reviews from jeznorth and NickPhura via 20959ec May 9, 2023 06:54
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@AlfredRosenthal AlfredRosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👪
Tried it out locally, looks good!

@curtisupshall curtisupshall merged commit 2ac5868 into dev May 9, 2023
@curtisupshall curtisupshall deleted the SIMSBIOHUB-30 branch May 9, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants