SIMSBIOHUB-11: Re-submit EML on project/survey changes

[NickPhura]

Overview

Links to Jira tickets

https://apps.nrs.gov.bc.ca/int/jira/browse/SIMSBIOHUB-11

Description of relevant changes

Project EML is submitted to BioHub when:

• Project created
• Project updated
• Survey created (new)
• Survey updated (new)
• Survey deleted

Survey EML is submitted to BioHub when:

• Survey created
• Survey updated
• Project updated (new)

PR Checklist

A list of items that are good to consider when making any changes.

Note: this list is not exhaustive, and not all items are always applicable.

Code

• New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
• I have avoided duplicating code when possible, moving re-usable pieces into functions
• I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
• My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
• My code changes account for null/undefined values and handle errors appropriately
• My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

• My code follows the established style conventions
• My code uses native material-ui components/icons/conventions when possible

Documentation

• I have commented my code sufficiently, such that an unfamiliar developer could understand my code
• I have added/updated README's and related documentation, as needed

Tests

• I have added/updated unit tests for any code I've added/updated
• I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

• I have run the linter and fixed any issues, as needed
  See the lint commands in package.json
• I have run the formatter and fixed any issues, as needed
  See the format commands in package.json

SonarCloud

• I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

[github-actions]

Openshift URLs for the PR Deployment:

• App Route: https://biohubbc-app-1021-af2668-dev.apps.silver.devops.gov.bc.ca/
• Api Route: https://biohubbc-api-1021-af2668-dev.apps.silver.devops.gov.bc.ca/
• Pods: https://console.apps.silver.devops.gov.bc.ca/k8s/ns/af2668-dev/pods?name=1021

[NickPhura]

This is ready for review, but leaving as a draft while we have lots of other PRs open.

[codecov]

Codecov Report

Merging #1021 (141a3e4) into dev (586a61a) will increase coverage by 0.00%.
The diff coverage is 73.68%.

@@           Coverage Diff           @@
##              dev    #1021   +/-   ##
=======================================
  Coverage   68.16%   68.16%           
=======================================
  Files         383      383           
  Lines       11882    11890    +8     
  Branches     2023     2023           
=======================================
+ Hits         8099     8105    +6     
- Misses       3314     3316    +2     
  Partials      469      469           

Impacted Files	Coverage Δ
api/src/openapi/schemas/project.ts	100.00% <ø> (ø)
api/src/paths/project/{projectId}/survey/create.ts	96.15% <ø> (ø)
...hs/project/{projectId}/survey/{surveyId}/delete.ts	94.59% <0.00%> (ø)
app/src/components/map/FeaturePopup.tsx	7.69% <0.00%> (-0.31%)	⬇️
api/src/paths/project/create.ts	96.00% <100.00%> (ø)
...hs/project/{projectId}/survey/{surveyId}/update.ts	96.29% <100.00%> (+0.14%)	⬆️
api/src/paths/project/{projectId}/update.ts	91.52% <100.00%> (ø)
api/src/services/project-service.ts	27.36% <100.00%> (+1.10%)	⬆️
api/src/services/survey-service.ts	81.87% <100.00%> (+0.34%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[github-actions]

Openshift URLs for the PR Deployment:

• App Route: https://biohubbc-app-1021-af2668-dev.apps.silver.devops.gov.bc.ca/
• Api Route: https://biohubbc-api-1021-af2668-dev.apps.silver.devops.gov.bc.ca/
• Pods: https://console.apps.silver.devops.gov.bc.ca/k8s/ns/af2668-dev/pods?name=1021

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
1.5% Duplication

[KjartanE]

🐱 Code looks good

[curtisupshall]

Code looks good; Manually tested survey creation, survey editing, and project editing; All work as expected!