SIMSBIOHUB-13: Lock Submitted Data and Files

[KjartanE]

Overview

Links to Jira tickets

• https://apps.nrs.gov.bc.ca/int/jira/browse/SIMSBIOHUB-13

Description of relevant changes

• {List all relevant changes, in particular anything that will help the reviewers test/verify this PR}

PR Checklist

A list of items that are good to consider when making any changes.

Note: this list is not exhaustive, and not all items are always applicable.

Code

• New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
• I have avoided duplicating code when possible, moving re-usable pieces into functions
• I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
• My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
• My code changes account for null/undefined values and handle errors appropriately
• My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

• My code follows the established style conventions
• My code uses native material-ui components/icons/conventions when possible

Documentation

• I have commented my code sufficiently, such that an unfamiliar developer could understand my code
• I have added/updated README's and related documentation, as needed

Tests

• I have added/updated unit tests for any code I've added/updated
• I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

• I have run the linter and fixed any issues, as needed
  See the lint commands in package.json
• I have run the formatter and fixed any issues, as needed
  See the format commands in package.json

SonarCloud

• I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

[github-actions]

Openshift URLs for the PR Deployment:

• App Route: https://biohubbc-app-1022-af2668-dev.apps.silver.devops.gov.bc.ca/
• Api Route: https://biohubbc-api-1022-af2668-dev.apps.silver.devops.gov.bc.ca/
• Pods: https://console.apps.silver.devops.gov.bc.ca/k8s/ns/af2668-dev/pods?name=1022

[codecov]

Codecov Report

Merging #1022 (b023e74) into dev (5a0a300) will increase coverage by 0.18%.
The diff coverage is 55.37%.

@@            Coverage Diff             @@
##              dev    #1022      +/-   ##
==========================================
+ Coverage   68.16%   68.35%   +0.18%     
==========================================
  Files         383      383              
  Lines       11890    11936      +46     
  Branches     2023     2033      +10     
==========================================
+ Hits         8105     8159      +54     
+ Misses       3316     3301      -15     
- Partials      469      476       +7     

Impacted Files	Coverage Δ
...attachments/list/AttachmentsListItemMenuButton.tsx	66.66% <ø> (ø)
...mponents/publish/ProjectListSubmissionAlertBar.tsx	30.43% <0.00%> (-2.90%)	⬇️
...c/components/publish/ProjectSubmissionAlertBar.tsx	3.33% <0.00%> (ø)
app/src/components/surveys/SurveysList.tsx	90.47% <ø> (+7.14%)	⬆️
...p/src/features/projects/list/ProjectsListTable.tsx	100.00% <ø> (+14.28%)	⬆️
app/src/features/projects/view/ProjectHeader.tsx	5.26% <0.00%> (ø)
.../summary-results/components/FileSummaryResults.tsx	7.69% <0.00%> (+0.28%)	⬆️
api/src/services/project-service.ts	26.29% <5.55%> (-1.08%)	⬇️
api/src/repositories/summary-repository.ts	83.82% <10.00%> (-8.83%)	⬇️
...rc/components/attachments/list/AttachmentsList.tsx	78.26% <25.00%> (-3.56%)	⬇️
... and 7 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[github-actions]

Openshift URLs for the PR Deployment:

• App Route: https://biohubbc-app-1022-af2668-dev.apps.silver.devops.gov.bc.ca/
• Api Route: https://biohubbc-api-1022-af2668-dev.apps.silver.devops.gov.bc.ca/
• Pods: https://console.apps.silver.devops.gov.bc.ca/k8s/ns/af2668-dev/pods?name=1022

[NickPhura]

@KjartanE handful of bugs/code smells to address

[NickPhura]

@KjartanE One issue I found:

Setup:

• I have a project with 1 survey (no other attachments)
• The survey has an observation uploaded (no other attachments).
• I submit the observation to biohub, successfully.

Result:

• The survey page banner/chip shows it is submitted (green) ✔️
• The project page banner/chip still shows it is unsubmitted, including the survey list chip (grey) ❌
• The project list page shows it is unsubmitted (grey) ❌

[sonarqubecloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
7.2% Duplication

[NickPhura]

Tested locally, including submitting observations to biohub.

[AlfredRosenthal]

🐶