Bug Fixes: delete project attachment, delete survey

[KjartanE]

Overview

Links to Jira tickets

• {List all applicable Jira tickets}

Description of relevant changes

• {List all relevant changes, in particular anything that will help the reviewers test/verify this PR}

PR Checklist

A list of items that are good to consider when making any changes.

Note: this list is not exhaustive, and not all items are always applicable.

Code

• New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
• I have avoided duplicating code when possible, moving re-usable pieces into functions
• I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
• My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
• My code changes account for null/undefined values and handle errors appropriately
• My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

• My code follows the established style conventions
• My code uses native material-ui components/icons/conventions when possible

Documentation

• I have commented my code sufficiently, such that an unfamiliar developer could understand my code
• I have added/updated README's and related documentation, as needed

Tests

• I have added/updated unit tests for any code I've added/updated
• I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

• I have run the linter and fixed any issues, as needed
  See the lint commands in package.json
• I have run the formatter and fixed any issues, as needed
  See the format commands in package.json

SonarCloud

• I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

[github-actions]

Openshift URLs for the PR Deployment:

• App Route: https://biohubbc-app-1023-af2668-dev.apps.silver.devops.gov.bc.ca/
• Api Route: https://biohubbc-api-1023-af2668-dev.apps.silver.devops.gov.bc.ca/
• Pods: https://console.apps.silver.devops.gov.bc.ca/k8s/ns/af2668-dev/pods?name=1023

[codecov]

Codecov Report

Merging #1023 (60f850d) into dev (3eb838d) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev    #1023      +/-   ##
==========================================
+ Coverage   68.08%   68.16%   +0.07%     
==========================================
  Files         383      383              
  Lines       11870    11882      +12     
  Branches     2023     2023              
==========================================
+ Hits         8082     8099      +17     
+ Misses       3319     3314       -5     
  Partials      469      469              

Impacted Files	Coverage Δ
api/src/repositories/user-repository.ts	97.87% <ø> (ø)
app/src/components/fields/CustomTextField.tsx	100.00% <ø> (ø)
...p/src/features/projects/list/ProjectsListTable.tsx	85.71% <ø> (ø)
...t/{projectId}/attachments/{attachmentId}/delete.ts	97.22% <100.00%> (+0.34%)	⬆️
api/src/repositories/history-publish-repository.ts	100.00% <100.00%> (ø)
api/src/services/history-publish-service.ts	92.45% <100.00%> (+0.29%)	⬆️
...src/features/projects/create/CreateProjectPage.tsx	73.62% <100.00%> (+5.49%)	⬆️
app/src/features/surveys/view/SurveyHeader.tsx	60.41% <100.00%> (+1.72%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[curtisupshall]

Code looks good! Had one comment.

[AlfredRosenthal]

⚒️

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.4% Duplication