Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SIMSBIOHUB-18: Fix application redirection links #1025

Merged
merged 69 commits into from
May 10, 2023
Merged

SIMSBIOHUB-18: Fix application redirection links #1025

merged 69 commits into from
May 10, 2023

Conversation

curtisupshall
Copy link
Contributor

@curtisupshall curtisupshall commented May 2, 2023 •
edited
Loading

Overview

Enhances URL redirection in the SIMS frontend.

Links to Jira tickets

Description of relevant changes

  • Fixes the application URL provided in Access Request email links
  • Adds a login endpoint to hook into Keycloak sign-in
  • Adds the useRedirect hook

curtisupshall and others added 30 commits April 26, 2023 13:55
@curtisupshall
SIMSBIOHUB-41: Create temporary, publicly-accessible home page in SIMS
cc0e1d6
@curtisupshall
SIMSBIOHUB-30: Initial commit
4af112a
@curtisupshall
SIMSBIOHUB-30: Theming
c0a84c2
@curtisupshall
SIMSBIOHUB-30: Add browser history
f6f6029
@curtisupshall
SIMSBIOHUB-30: Created login stub
7107efe
@curtisupshall
SIMSBIOHUB-30: Generate absolute redirect uri; Styling
0575fc8
@curtisupshall
SIMSBIOHUB-30: More styling
f3fd1ec
@curtisupshall
SIMSBIOHUB-30: Added tests
e99b3de
@curtisupshall
SIMSBIOHUB-30: clean-up
4ba1424
@curtisupshall
Merge branch 'dev' into SIMSBIOHUB-30
2f07448
@curtisupshall
SIMSBIOHUB-30: Make fix
3b44fa3
@curtisupshall
Merge branch 'dev' into SIMSBIOHUB-30
37b0982
@curtisupshall
SIMSBIOHUB-18: Fix prod URL to point to sims.nrs
1aaaafb
@curtisupshall
Merge branch 'SIMSBIOHUB-30' into SIMSBIOHUB-18
a72b289
@curtisupshall
SIMSBIOHUB-18: Create redirect helper hook
89ea284
@curtisupshall
SIMSBIOHUB-18: Fix bug in useKeycloakWrapper
f5bd147
@curtisupshall
SIMSBIOHUB-30: Create LoginPage component
9578ea3
@curtisupshall
Merge branch 'dev' into SIMSBIOHUB-30
bf1583b
@KjartanE
Merge branch 'dev' into SIMSBIOHUB-30
da5dabc
@curtisupshall
Merge branch 'SIMSBIOHUB-30' of github.com:bcgov/biohubbc into SIMSBI…
0693fc1 
…OHUB-30
@curtisupshall
SIMSBIOHUB-30: Added test coverage
a4676c4
@curtisupshall
SIMSBIOHUB-30: auth helper test coverage
4b74930
@curtisupshall
SIMSBIOHUB-30: Test coverage
7920f30
@curtisupshall
SIMSBIOHUB-30: Test coverage 2
a0cc501
@curtisupshall
SIMSBIOHUB-30: Moved Landing Page actions into its own component
bc4e96c
@curtisupshall
SIMSBIOHUB-30: Begin creating admin activities repo+service files WIP
bdbc325
@curtisupshall
Merge branch 'dev' into SIMSBIOHUB-30
79f5241
@curtisupshall
SIMSBIOHUB-30: Add todo comment
490e15a
@curtisupshall
SIMSBIOHUB-30: WIP; Completed admnactvty service methods.
1202447
@curtisupshall
SIMSBIOHUB-30: Complete impl of adminactvtys standing in frontend
b34a576
@curtisupshall curtisupshall changed the title SIMSBIOHUB-18 SIMSBIOHUB-18: Fix application redirection links May 8, 2023
@curtisupshall curtisupshall added the Do Not Merge PR should not be merged label May 9, 2023
Base automatically changed from SIMSBIOHUB-30 to dev May 9, 2023 18:03
@curtisupshall curtisupshall marked this pull request as ready for review May 9, 2023 18:16
@github-actions
Copy link

github-actions bot commented May 9, 2023

Openshift URLs for the PR Deployment:

@curtisupshall curtisupshall removed the Do Not Merge PR should not be merged label May 9, 2023
@curtisupshall curtisupshall removed the Early Feedback Welcome PR is not finished, but early review feedback is welcomed label May 9, 2023
AlfredRosenthal
AlfredRosenthal approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@AlfredRosenthal AlfredRosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦞

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@curtisupshall curtisupshall merged commit 07e3f1d into dev May 10, 2023
@curtisupshall curtisupshall deleted the SIMSBIOHUB-18 branch May 10, 2023 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeznorth jeznorth jeznorth left review comments

@AlfredRosenthal AlfredRosenthal AlfredRosenthal approved these changes

@anissa-agahchen anissa-agahchen anissa-agahchen approved these changes

@NickPhura NickPhura Awaiting requested review from NickPhura

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@curtisupshall @NickPhura @jeznorth @anissa-agahchen @AlfredRosenthal @KjartanE