SIMSBIOHUB-24: First Nations as a funding source on projects/ surveys

[AlfredRosenthal]

Overview

Links to Jira tickets

SIMSBIOHUBS-24

Description of relevant changes

• First nations will now appear in a searchable drop down when adding a funding source to a project
• API endpoints updated to account for first nations name/ id
• updated repos to pull/ save first nations name/ id when appropriate
• Updated front end to account for new strings/ types

PR Testing

1. Pull branch and run migrations
2. Create/ Edit a project
3. Select Add funding source
4. Select an agency and you'll see a typeahead for first nations and agencies (start typing first for a quick example)
5. Select an agency, complete the form and save the changes to a project
6. Create/ Edit a survey associated to the previous project
7. Select the funding sources and pick the newly added funding source (this will fail if BioHub isn't running locally as well)
8. Save the changes and reload the page
9. Edit project and modify a funding sources
10. See changes reflected in survey

Code

• New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
• I have avoided duplicating code when possible, moving re-usable pieces into functions
• I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
• My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
• My code changes account for null/undefined values and handle errors appropriately
• My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

• My code follows the established style conventions
• My code uses native material-ui components/icons/conventions when possible

Documentation

• I have commented my code sufficiently, such that an unfamiliar developer could understand my code
• I have added/updated README's and related documentation, as needed

Tests

• I have added/updated unit tests for any code I've added/updated
• I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

• I have run the linter and fixed any issues, as needed
  See the lint commands in package.json
• I have run the formatter and fixed any issues, as needed
  See the format commands in package.json

SonarCloud

• I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

[curtisupshall]

Good looks good! Just had a handful of nitpicks

[sonarqubecloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
5.9% Duplication

[curtisupshall]

Looks good!