Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-32: Sort Project List by Column Headers #1029

Merged
merged 43 commits into from
Jun 2, 2023
Merged

Conversation

curtisupshall
Copy link
Contributor

@curtisupshall curtisupshall commented May 11, 2023

Overview

Updates some frontend libraries to allow the use of MUI DataGrids, which is used to enable sorting for the Projects list table.

Links to Jira tickets

Description of relevant changes

  • Installed the MUI DataGrid library
  • Updated the Projects list table to use the MUI DataGrid
  • Updates React from version 16 to 17
  • Updated react-scripts from version 3 to version 5
  • Updated numerous packages and fixed tests

@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #1029 (c56a18f) into dev (bd35f1e) will decrease coverage by 0.56%.
The diff coverage is 61.84%.

@@            Coverage Diff             @@
##              dev    #1029      +/-   ##
==========================================
- Coverage   68.26%   67.71%   -0.56%     
==========================================
  Files         392      394       +2     
  Lines       12105    12196      +91     
  Branches     2067     2076       +9     
==========================================
- Hits         8264     8258       -6     
- Misses       3336     3424      +88     
- Partials      505      514       +9     
Impacted Files Coverage Δ
.../src/components/attachments/EditReportMetaForm.tsx 23.52% <ø> (ø)
.../src/components/attachments/FileUploadWithMeta.tsx 45.45% <ø> (ø)
app/src/components/attachments/ReportMeta.tsx 28.57% <ø> (ø)
app/src/components/attachments/ReportMetaForm.tsx 23.52% <ø> (ø)
app/src/components/boundary/MapBoundary.tsx 50.00% <ø> (ø)
app/src/components/dialog/EditDialog.tsx 90.00% <ø> (-10.00%) ⬇️
...rc/components/fields/AutocompleteFreeSoloField.tsx 66.66% <0.00%> (ø)
app/src/components/fields/CustomFieldArray.tsx 0.00% <0.00%> (ø)
app/src/components/formik/ScrollToFormikError.tsx 48.57% <0.00%> (ø)
app/src/components/map/DatasetPopup.tsx 8.33% <0.00%> (-0.37%) ⬇️
... and 49 more

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@curtisupshall curtisupshall changed the title SIMSBIOHUB-32 SIMSBIOHUB-32: Sort Project List by Column Headers May 25, 2023
@curtisupshall curtisupshall marked this pull request as ready for review May 25, 2023 19:54
@curtisupshall curtisupshall requested a review from NickPhura June 1, 2023 04:35
NickPhura
NickPhura previously approved these changes Jun 2, 2023
NickPhura
NickPhura previously approved these changes Jun 2, 2023
Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚗

al-rosenthal
al-rosenthal previously approved these changes Jun 2, 2023
Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

NickPhura
NickPhura previously approved these changes Jun 2, 2023
@curtisupshall curtisupshall dismissed stale reviews from NickPhura and al-rosenthal via c56a18f June 2, 2023 22:59
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧇

@curtisupshall curtisupshall merged commit 485498c into dev Jun 2, 2023
@curtisupshall curtisupshall deleted the SIMSBIOHUB-32 branch June 2, 2023 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants