Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing console logs #1034

Merged
merged 2 commits into from
May 16, 2023
Merged

Removing console logs #1034

merged 2 commits into from
May 16, 2023

Conversation

al-rosenthal
Copy link
Contributor

Overview

Links to Jira tickets

  • {List all applicable Jira tickets}

Description of relevant changes

  • {List all relevant changes, in particular anything that will help the reviewers test/verify this PR}

PR Checklist

A list of items that are good to consider when making any changes.

Note: this list is not exhaustive, and not all items are always applicable.

Code

  • New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
  • I have avoided duplicating code when possible, moving re-usable pieces into functions
  • I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
  • My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
  • My code changes account for null/undefined values and handle errors appropriately
  • My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

  • My code follows the established style conventions
  • My code uses native material-ui components/icons/conventions when possible

Documentation

  • I have commented my code sufficiently, such that an unfamiliar developer could understand my code
  • I have added/updated README's and related documentation, as needed

Tests

  • I have added/updated unit tests for any code I've added/updated
  • I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

  • I have run the linter and fixed any issues, as needed
    See the lint commands in package.json
  • I have run the formatter and fixed any issues, as needed
    See the format commands in package.json

SonarCloud

  • I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Merging #1034 (c0bcec7) into dev (68469e8) will increase coverage by 12.96%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##              dev    #1034       +/-   ##
===========================================
+ Coverage   68.22%   81.18%   +12.96%     
===========================================
  Files         386      177      -209     
  Lines       12032     7176     -4856     
  Branches     2061     1251      -810     
===========================================
- Hits         8209     5826     -2383     
+ Misses       3317     1041     -2276     
+ Partials      506      309      -197     
Impacted Files Coverage Δ
api/src/repositories/survey-repository.ts 94.85% <ø> (-0.12%) ⬇️

... and 209 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@al-rosenthal al-rosenthal merged commit cb6bf05 into dev May 16, 2023
@al-rosenthal al-rosenthal deleted the clean-up branch May 16, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants