Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-8-2: Update duplicate key validation rule to account for empty cells. #1037

Merged
merged 7 commits into from
May 29, 2023

Conversation

NickPhura
Copy link
Collaborator

Overview

Links to Jira tickets

  • {List all applicable Jira tickets}

Description of relevant changes

  • Update duplicate key validation rule to account for empty cells.
  • Update unit tests.

PR Checklist

A list of items that are good to consider when making any changes.

Note: this list is not exhaustive, and not all items are always applicable.

Code

  • New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
  • I have avoided duplicating code when possible, moving re-usable pieces into functions
  • I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
  • My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
  • My code changes account for null/undefined values and handle errors appropriately
  • My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

  • My code follows the established style conventions
  • My code uses native material-ui components/icons/conventions when possible

Documentation

  • I have commented my code sufficiently, such that an unfamiliar developer could understand my code
  • I have added/updated README's and related documentation, as needed

Tests

  • I have added/updated unit tests for any code I've added/updated
  • I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

  • I have run the linter and fixed any issues, as needed
    See the lint commands in package.json
  • I have run the formatter and fixed any issues, as needed
    See the format commands in package.json

SonarCloud

  • I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Merging #1037 (bbdd537) into dev (f3ca89f) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev    #1037      +/-   ##
==========================================
+ Coverage   67.99%   68.01%   +0.01%     
==========================================
  Files         392      392              
  Lines       12126    12127       +1     
  Branches     2063     2064       +1     
==========================================
+ Hits         8245     8248       +3     
+ Misses       3380     3379       -1     
+ Partials      501      500       -1     
Impacted Files Coverage Δ
.../utils/media/xlsx/transformation/xlsx-transform.ts 3.34% <ø> (+0.01%) ⬆️
...rc/utils/media/csv/validation/csv-row-validator.ts 89.34% <100.00%> (+1.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@NickPhura NickPhura added the Not Ready For Review Addressing feedback and/or refactoring label May 29, 2023
@NickPhura NickPhura removed the Not Ready For Review Addressing feedback and/or refactoring label May 29, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️

@NickPhura NickPhura merged commit f7c106a into dev May 29, 2023
@NickPhura NickPhura deleted the SIMSBIOHUB-8-2 branch May 29, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants