Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-61: See Error Message When Submitting Artifacts Fails #1040

Merged
merged 26 commits into from
Jun 2, 2023

Conversation

curtisupshall
Copy link
Contributor

Overview

When a request to submit data to Biohub fails, the user should see an appropriate error dialog.

Links to Jira tickets

Description of relevant changes

  • Removed duplicate code by creating the LoadingButton component as a stand-in for the analogous MUI Lab version
  • Refactored the Project and Survey submission components
  • Added an error dialog when the request to submit to Biohub fails

Testing Procedure

  1. Sign into SIMS in an environment that procludes submitting to Biohub (or set BACKBONE_INTAKE_ENABLED to false).
  2. Create or navigate to a project that has unsubmitted documents.
  3. Submit at least one or more documents to Biohub. You should:
  • See an error dialog.
  1. Create or navigate to a survey that has unsubmitted artifacts.
  2. Submit at least one or more artifacts, summary results or observations data to Biohub. You should:
  • See an error dialog.

@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Merging #1040 (30a4159) into dev (6f8d32d) will increase coverage by 0.15%.
The diff coverage is 34.48%.

@@            Coverage Diff             @@
##              dev    #1040      +/-   ##
==========================================
+ Coverage   68.11%   68.26%   +0.15%     
==========================================
  Files         392      392              
  Lines       12141    12105      -36     
  Branches     2065     2067       +2     
==========================================
- Hits         8270     8264       -6     
+ Misses       3368     3336      -32     
- Partials      503      505       +2     
Impacted Files Coverage Δ
app/src/components/dialog/DialogVisual.tsx 0.00% <0.00%> (ø)
...ents/dialog/attachments/EditFileWithMetaDialog.tsx 6.66% <ø> (-4.45%) ⬇️
...ts/dialog/attachments/FileUploadWithMetaDialog.tsx 60.00% <ø> (-1.12%) ⬇️
app/src/features/projects/view/ProjectHeader.tsx 5.12% <0.00%> (-0.14%) ⬇️
...atures/surveys/view/components/SurveyStudyArea.tsx 75.34% <ø> (ø)
app/src/hooks/api/usePublishApi.ts 35.71% <ø> (ø)
app/src/pages/access/AccessRequestPage.tsx 70.00% <ø> (-0.59%) ⬇️
...pp/src/components/publish/PublishProjectDialog.tsx 19.04% <19.04%> (ø)
app/src/components/publish/PublishSurveyDialog.tsx 36.84% <36.84%> (ø)
app/src/components/dialog/SubmitBiohubDialog.tsx 43.33% <41.66%> (+3.33%) ⬆️
... and 4 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@curtisupshall curtisupshall requested a review from NickPhura June 2, 2023 18:30
@NickPhura
Copy link
Collaborator

Looks great, just the linter complaining about 1 file

@curtisupshall curtisupshall requested a review from NickPhura June 2, 2023 19:01
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍍

Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ran locally, looks good!
🕶️

@curtisupshall curtisupshall merged commit bd35f1e into dev Jun 2, 2023
@curtisupshall curtisupshall deleted the SIMSBIOHUB-61-dialog branch June 2, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants