Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Make Styles Issue #1041

Merged
merged 3 commits into from
Jun 5, 2023
Merged

Bugfix: Make Styles Issue #1041

merged 3 commits into from
Jun 5, 2023

Conversation

al-rosenthal
Copy link
Contributor

Overview

Description of relevant changes

  • fixed issue with import that was causing the page to crash

PR Checklist

A list of items that are good to consider when making any changes.

Note: this list is not exhaustive, and not all items are always applicable.

Code

  • New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
  • I have avoided duplicating code when possible, moving re-usable pieces into functions
  • I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
  • My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
  • My code changes account for null/undefined values and handle errors appropriately
  • My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

  • My code follows the established style conventions
  • My code uses native material-ui components/icons/conventions when possible

Documentation

  • I have commented my code sufficiently, such that an unfamiliar developer could understand my code
  • I have added/updated README's and related documentation, as needed

Tests

  • I have added/updated unit tests for any code I've added/updated
  • I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

  • I have run the linter and fixed any issues, as needed
    See the lint commands in package.json
  • I have run the formatter and fixed any issues, as needed
    See the format commands in package.json

SonarCloud

  • I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

NickPhura
NickPhura previously approved these changes Jun 5, 2023
anissa-agahchen
anissa-agahchen previously approved these changes Jun 5, 2023
jeznorth
jeznorth previously approved these changes Jun 5, 2023
NickPhura
NickPhura previously approved these changes Jun 5, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #1041 (70888ad) into dev (485498c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #1041   +/-   ##
=======================================
  Coverage   67.71%   67.71%           
=======================================
  Files         394      394           
  Lines       12196    12196           
  Branches     2076     2076           
=======================================
  Hits         8258     8258           
  Misses       3424     3424           
  Partials      514      514           
Impacted Files Coverage Δ
app/src/components/buttons/LoadingButton.tsx 100.00% <ø> (ø)
app/src/test-helpers/test-utils.tsx 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@al-rosenthal al-rosenthal merged commit 83a6431 into dev Jun 5, 2023
@al-rosenthal al-rosenthal deleted the BUGFIX-MakeStyles branch June 5, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants