SIMSBIOHUB-117: File deletion sends request to BioHub

[al-rosenthal]

Overview

Links to Jira tickets

SIMSBIOHUB-117

Description of relevant changes

• Delete endpoint modified to send a request to BioHub to deleted submitted files

PR Checklist

A list of items that are good to consider when making any changes.

Note: this list is not exhaustive, and not all items are always applicable.

Code

• New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
• I have avoided duplicating code when possible, moving re-usable pieces into functions
• I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
• My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
• My code changes account for null/undefined values and handle errors appropriately
• My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

• My code follows the established style conventions
• My code uses native material-ui components/icons/conventions when possible

Documentation

• I have commented my code sufficiently, such that an unfamiliar developer could understand my code
• I have added/updated README's and related documentation, as needed

Tests

• I have added/updated unit tests for any code I've added/updated
• I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

• I have run the linter and fixed any issues, as needed
  See the lint commands in package.json
• I have run the formatter and fixed any issues, as needed
  See the format commands in package.json

SonarCloud

• I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

[github-actions]

Openshift URLs for the PR Deployment:

• App Route: https://biohubbc-app-1046-af2668-dev.apps.silver.devops.gov.bc.ca/
• Api Route: https://biohubbc-api-1046-af2668-dev.apps.silver.devops.gov.bc.ca/
• Pods: https://console.apps.silver.devops.gov.bc.ca/k8s/ns/af2668-dev/pods?name=1046

[github-actions]

Openshift URLs for the PR Deployment:

• App Route: https://biohubbc-app-1046-af2668-dev.apps.silver.devops.gov.bc.ca/
• Api Route: https://biohubbc-api-1046-af2668-dev.apps.silver.devops.gov.bc.ca/
• Pods: https://console.apps.silver.devops.gov.bc.ca/k8s/ns/af2668-dev/pods?name=1046

[codecov]

Codecov Report

Merging #1046 (dd33fe2) into dev (a754dbc) will decrease coverage by 0.12%.
The diff coverage is 75.75%.

@@            Coverage Diff             @@
##              dev    #1046      +/-   ##
==========================================
- Coverage   67.59%   67.47%   -0.12%     
==========================================
  Files         392      392              
  Lines       12232    12264      +32     
  Branches     2096     2102       +6     
==========================================
+ Hits         8268     8275       +7     
- Misses       3445     3467      +22     
- Partials      519      522       +3     

Impacted Files	Coverage Δ
api/src/repositories/attachment-repository.ts	91.00% <0.00%> (-2.82%)	⬇️
...attachments/list/AttachmentsListItemMenuButton.tsx	57.14% <40.00%> (-6.02%)	⬇️
api/src/services/platform-service.ts	90.05% <60.00%> (-1.28%)	⬇️
...t/{projectId}/attachments/{attachmentId}/delete.ts	92.30% <75.00%> (-4.92%)	⬇️
...ey/{surveyId}/attachments/{attachmentId}/delete.ts	92.30% <75.00%> (-4.92%)	⬇️
api/src/services/attachment-service.ts	99.27% <97.05%> (-0.73%)	⬇️
.../features/projects/view/ProjectAttachmentsList.tsx	57.14% <100.00%> (+2.79%)	⬆️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[curtisupshall]

Code looks good 🦡

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.9% Duplication

[KjartanE]

🐈

[NickPhura]

I think the type is Other technically