Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SIMSBIOHUB-127: Update inferred layers code #1048

Merged
merged 23 commits into from
Jul 17, 2023
Merged

SIMSBIOHUB-127: Update inferred layers code #1048

merged 23 commits into from
Jul 17, 2023

Conversation

NickPhura
Copy link
Collaborator

@NickPhura NickPhura commented Jun 29, 2023 •
edited
Loading

Overview

Links to Jira tickets

https://apps.nrs.gov.bc.ca/int/jira/browse/SIMSBIOHUB-127

Description of relevant changes

  • Add backend services for fetching data from the BCGW service
  • Add new endpoint for fetching inferred region information (moving away from the frontend making these calls, because we probably need to backend to also make these calls, and don't want to duplicate the same code in both places).
  • Some misc updates to a geojson type name.

TODO

  • Write tests (api/app)

@github-actions
Copy link

Openshift URLs for the PR Deployment:

@codecov
Copy link

codecov bot commented Jun 29, 2023 •
edited
Loading

Codecov Report

Merging #1048 (37c007f) into dev (5fdc193) will increase coverage by 0.27%.
The diff coverage is 80.06%.

@@            Coverage Diff             @@
##              dev    #1048      +/-   ##
==========================================
+ Coverage   67.47%   67.74%   +0.27%     
==========================================
  Files         394      401       +7     
  Lines       12264    12390     +126     
  Branches     2085     2090       +5     
==========================================
+ Hits         8275     8394     +119     
- Misses       3465     3466       +1     
- Partials      524      530       +6
Impacted Files Coverage Δ
api/src/services/platform-service.ts 90.05% <ø> (ø)
app/src/components/boundary/MapBoundary.tsx 50.00% <ø> (ø)
app/src/components/map/wfs-utils.tsx 5.26% <ø> (-52.35%) ⬇️
...ures/projects/view/components/LocationBoundary.tsx 4.68% <ø> (ø)
.../src/features/surveys/components/StudyAreaForm.tsx 100.00% <ø> (ø)
...atures/surveys/view/components/SurveyStudyArea.tsx 75.34% <ø> (ø)
app/src/hooks/useBioHubApi.ts 5.88% <0.00%> (-0.37%) ⬇️
app/src/utils/mapLayersHelpers.ts 100.00% <ø> (+85.00%) ⬆️
app/src/components/map/MapContainer.tsx 61.53% <27.27%> (-16.59%) ⬇️
api/src/repositories/postgis-repository.ts 45.45% <45.45%> (ø)
... and 14 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@NickPhura NickPhura marked this pull request as ready for review July 4, 2023 20:53
@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Openshift URLs for the PR Deployment:

curtisupshall
curtisupshall reviewed Jul 4, 2023
View reviewed changes
api/src/services/bcgw-layer-service.ts Outdated Show resolved Hide resolved
api/src/services/bcgw-layer-service.ts Outdated Show resolved Hide resolved
api/src/services/bcgw-layer-service.ts Show resolved Hide resolved
api/src/services/bcgw-layer-service.ts Show resolved Hide resolved
al-rosenthal
al-rosenthal reviewed Jul 5, 2023
View reviewed changes
Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ran this locally, seems to work great

api/src/paths/spatial/regions.ts Outdated Show resolved Hide resolved
api/src/services/bcgw-layer-service.ts Outdated Show resolved Hide resolved
api/src/services/postgis-service.ts Show resolved Hide resolved
api/src/services/postgis-service.ts Outdated Show resolved Hide resolved
al-rosenthal
al-rosenthal previously approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗺️

curtisupshall
curtisupshall previously approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@curtisupshall curtisupshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good! +1 for added type coverage 👏

@al-rosenthal al-rosenthal dismissed stale reviews from curtisupshall and themself via fbe77dd July 10, 2023 18:04
al-rosenthal
al-rosenthal approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐤

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
4.6% 4.6% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@al-rosenthal al-rosenthal merged commit 6f7578f into dev Jul 17, 2023
@al-rosenthal al-rosenthal deleted the SIMSBIOHUB-127 branch July 17, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curtisupshall curtisupshall curtisupshall approved these changes

@al-rosenthal al-rosenthal al-rosenthal approved these changes

@KjartanE KjartanE Awaiting requested review from KjartanE

@AlfredRosenthal AlfredRosenthal Awaiting requested review from AlfredRosenthal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NickPhura @al-rosenthal @curtisupshall