Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-129: Upgrade to MUI V5 #1050

Merged
merged 25 commits into from
Jul 17, 2023
Merged

SIMSBIOHUB-129: Upgrade to MUI V5 #1050

merged 25 commits into from
Jul 17, 2023

Conversation

curtisupshall
Copy link
Contributor

@curtisupshall curtisupshall commented Jul 5, 2023

Overview

We are currently using MUI version 4, which is now outdated. This PR updates MUI to version 5, similar to the update performed last year in BioHub.

Links to Jira tickets

Description of relevant changes

  • Update MUI to version 5, including updates to component imports and theming

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #1050 (7bd4431) into dev (6f7578f) will decrease coverage by 0.03%.
The diff coverage is 48.07%.

@@            Coverage Diff             @@
##              dev    #1050      +/-   ##
==========================================
- Coverage   67.74%   67.72%   -0.03%     
==========================================
  Files         401      401              
  Lines       12390    12408      +18     
  Branches     2090     2093       +3     
==========================================
+ Hits         8394     8403       +9     
- Misses       3466     3474       +8     
- Partials      530      531       +1     
Impacted Files Coverage Δ
...pp/src/components/attachments/EditFileWithMeta.tsx 0.00% <ø> (ø)
.../src/components/attachments/EditReportMetaForm.tsx 23.52% <ø> (ø)
.../src/components/attachments/FileUploadWithMeta.tsx 45.45% <ø> (ø)
app/src/components/attachments/ReportMeta.tsx 28.57% <ø> (ø)
app/src/components/attachments/ReportMetaForm.tsx 23.52% <ø> (ø)
...rc/components/attachments/list/AttachmentsList.tsx 75.00% <ø> (ø)
...attachments/list/AttachmentsListItemMenuButton.tsx 57.14% <ø> (ø)
...rc/components/boundary/FullScreenViewMapDialog.tsx 40.00% <ø> (ø)
...rc/components/boundary/InferredLocationDetails.tsx 60.00% <ø> (ø)
app/src/components/buttons/LoadingButton.tsx 100.00% <ø> (ø)
... and 138 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@curtisupshall curtisupshall marked this pull request as ready for review July 13, 2023 20:40
al-rosenthal
al-rosenthal previously approved these changes Jul 13, 2023
Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕶️

KjartanE
KjartanE previously approved these changes Jul 14, 2023
Copy link
Contributor

@KjartanE KjartanE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

o7

al-rosenthal
al-rosenthal previously approved these changes Jul 17, 2023
Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍦

@NickPhura NickPhura dismissed stale reviews from al-rosenthal and KjartanE via 9c084de July 17, 2023 18:10
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.2% 0.2% Duplication

Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍦

Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐛

@curtisupshall curtisupshall merged commit bb9f443 into dev Jul 17, 2023
@curtisupshall curtisupshall deleted the SIMSBIOHUB-129 branch July 17, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants