UI Cleanup + Misc Bug FIxes

[NickPhura]

Overview

Links to Jira tickets

• {List all applicable Jira tickets}

Description of relevant changes

• {List all relevant changes, in particular anything that will help the reviewers test/verify this PR}

PR Checklist

A list of items that are good to consider when making any changes.

Note: this list is not exhaustive, and not all items are always applicable.

Code

• New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
• I have avoided duplicating code when possible, moving re-usable pieces into functions
• I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
• My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
• My code changes account for null/undefined values and handle errors appropriately
• My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

• My code follows the established style conventions
• My code uses native material-ui components/icons/conventions when possible

Documentation

• I have commented my code sufficiently, such that an unfamiliar developer could understand my code
• I have added/updated README's and related documentation, as needed

Tests

• I have added/updated unit tests for any code I've added/updated
• I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

• I have run the linter and fixed any issues, as needed
  See the lint commands in package.json
• I have run the formatter and fixed any issues, as needed
  See the format commands in package.json

SonarCloud

• I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

[github-actions]

Openshift URLs for the PR Deployment:

• App Route: https://biohubbc-app-1054-af2668-dev.apps.silver.devops.gov.bc.ca/
• Api Route: https://biohubbc-api-1054-af2668-dev.apps.silver.devops.gov.bc.ca/
• Pods: https://console.apps.silver.devops.gov.bc.ca/k8s/ns/af2668-dev/pods?name=1054

[codecov]

Codecov Report

Merging #1054 (01f442e) into dev (96d7e49) will decrease coverage by 0.02%.
The diff coverage is 17.24%.

@@            Coverage Diff             @@
##              dev    #1054      +/-   ##
==========================================
- Coverage   67.72%   67.70%   -0.02%     
==========================================
  Files         401      401              
  Lines       12408    12397      -11     
  Branches     2093     2093              
==========================================
- Hits         8403     8394       -9     
+ Misses       3474     3472       -2     
  Partials      531      531              

Impacted Files	Coverage Δ
.../src/paths/project/{projectId}/participants/get.ts	96.00% <ø> (ø)
api/src/paths/user/{userId}/get.ts	95.65% <ø> (ø)
...c/repositories/project-participation-repository.ts	83.33% <ø> (ø)
...rc/components/attachments/list/AttachmentsList.tsx	73.68% <ø> (-1.32%)	⬇️
app/src/components/boundary/MapBoundary.tsx	48.48% <0.00%> (ø)
app/src/components/chips/SubmitStatusChip.tsx	46.66% <ø> (ø)
app/src/components/dialog/RequestDialog.tsx	100.00% <ø> (ø)
app/src/components/layout/Header.tsx	80.00% <ø> (ø)
...mponents/publish/ProjectListSubmissionAlertBar.tsx	30.43% <0.00%> (ø)
...c/components/publish/ProjectSubmissionAlertBar.tsx	3.33% <0.00%> (ø)
... and 33 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[curtisupshall]

Welcome changes 😀 Code looks good! 👨‍💻

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
2.1% Duplication

[al-rosenthal]

🕶️