SIMSBIOHUB-148: Create New Agency Database Table to Support All Agencies

[NickPhura]

Links to Jira Tickets

https://apps.nrs.gov.bc.ca/int/jira/browse/SIMSBIOHUB-148

Description of Changes

Funding Source -> Agency

• New migration to update existing funding_source table to agency.
  • Update columns, indexes, constraints, sequences, etc that used funding_source in their name. Rename to use agency.
  • Inserts new agency values (from static coordinator agency list)
• Removed static coordinator agency list
• Update tr_project_funding_source trigger to reference renamed agency table and columns.
• Rename instances of functions/variables that use funding_source to use agency
  • Renamed/expanded some shortened variable names fs (aka: funding_source) to agency
  • Related: expanded some other related shortened variable names pfs to project_funding_source for clarity
• Small fix for issue in region-service in Dev (including in this PR for simplicity)

Other

• Add migration to update miss-spelled triggers for region tables (added in from a previous PR: SIMSBIOHUB-141: Update Database to Accommodate Region Tables for Projects and Surveys #1051).

Documentation

• Updated database README to add documentation on database naming conventions, and sample migrations, and things to consider when writing a migration, etc.

Testing Notes

• Focus testing effort on anything related to Funding (project and survey level).
  • The app should function the exact same as before.

[github-actions]

Openshift URLs for the PR Deployment:

• App Route: https://biohubbc-app-1057-af2668-dev.apps.silver.devops.gov.bc.ca/
• Api Route: https://biohubbc-api-1057-af2668-dev.apps.silver.devops.gov.bc.ca/
• Pods: https://console.apps.silver.devops.gov.bc.ca/k8s/ns/af2668-dev/pods?name=1057

[codecov]

Codecov Report

Merging #1057 (ef5e3e3) into dev (afaf9a1) will decrease coverage by 0.03%.
The diff coverage is 36.36%.

@@            Coverage Diff             @@
##              dev    #1057      +/-   ##
==========================================
- Coverage   67.76%   67.73%   -0.03%     
==========================================
  Files         403      403              
  Lines       12481    12473       -8     
  Branches     2101     2101              
==========================================
- Hits         8458     8449       -9     
  Misses       3489     3489              
- Partials      534      535       +1     

Files Changed	Coverage Δ
api/src/constants/codes.ts	100.00% <ø> (ø)
api/src/models/survey-view.ts	100.00% <ø> (ø)
api/src/paths/codes.ts	100.00% <ø> (ø)
api/src/paths/project/{projectId}/survey/list.ts	96.66% <ø> (ø)
...aths/project/{projectId}/survey/{surveyId}/view.ts	95.83% <ø> (ø)
api/src/repositories/survey-repository.ts	94.85% <ø> (ø)
...eatures/projects/components/ProjectFundingForm.tsx	78.37% <ø> (ø)
app/src/features/projects/edit/EditProjectForm.tsx	0.00% <0.00%> (ø)
.../features/projects/list/ProjectsListFilterForm.tsx	13.33% <0.00%> (ø)
...p/src/features/projects/list/ProjectsListTable.tsx	59.09% <ø> (ø)
... and 12 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[github-actions]

Openshift URLs for the PR Deployment:

• App Route: https://biohubbc-app-1057-af2668-dev.apps.silver.devops.gov.bc.ca/
• Api Route: https://biohubbc-api-1057-af2668-dev.apps.silver.devops.gov.bc.ca/
• Pods: https://console.apps.silver.devops.gov.bc.ca/k8s/ns/af2668-dev/pods?name=1057

[curtisupshall]

Code looks good!

[al-rosenthal]

ran locally and things are working as expected. Great examples in the read me

[al-rosenthal]

🦖

[sonarqubecloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
9.1% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

[KjartanE]

Ran locally, works as intended! 😹