Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-144-2: Project Role updates #1065

Merged
merged 44 commits into from
Aug 4, 2023
Merged

SIMSBIOHUB-144-2: Project Role updates #1065

merged 44 commits into from
Aug 4, 2023

Conversation

al-rosenthal
Copy link
Contributor

Links to Jira Tickets

SIMSBIOHUB-144

Description of Changes

  • Updated Project role enum
  • Added Project permissions
  • Updated role guards for new permissions
  • Added zod schema for user objects
  • Updated paths/ endpoints to account for new schema

Testing Notes

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #1065 (68aadfb) into dev (847d0b3) will decrease coverage by 0.11%.
The diff coverage is 73.23%.

@@            Coverage Diff             @@
##              dev    #1065      +/-   ##
==========================================
- Coverage   67.68%   67.57%   -0.11%     
==========================================
  Files         403      403              
  Lines       12489    12509      +20     
  Branches     2092     2088       -4     
==========================================
  Hits         8453     8453              
- Misses       3499     3522      +23     
+ Partials      537      534       -3     
Files Changed Coverage Δ
...src/paths/project/{projectId}/participants/self.ts 100.00% <ø> (ø)
api/src/paths/user/list.ts 85.71% <ø> (ø)
api/src/paths/user/self.ts 96.00% <ø> (ø)
api/src/paths/user/{userId}/get.ts 95.65% <ø> (ø)
...repositories/administrative-activity-repository.ts 92.50% <ø> (ø)
api/src/repositories/draft-repository.ts 93.33% <ø> (ø)
api/src/repositories/history-publish-repository.ts 92.59% <ø> (ø)
api/src/repositories/permit-repository.ts 100.00% <ø> (ø)
api/src/repositories/postgis-repository.ts 45.45% <ø> (ø)
api/src/services/project-participation-service.ts 100.00% <ø> (ø)
... and 79 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@al-rosenthal al-rosenthal marked this pull request as ready for review August 2, 2023 23:01
@NickPhura NickPhura self-assigned this Aug 3, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 4, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.4% 3.4% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@al-rosenthal al-rosenthal merged commit eb4d16d into dev Aug 4, 2023
@al-rosenthal al-rosenthal deleted the SIMSBIOHUB-144-2 branch August 4, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants