-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SIMSBIOHUB-161/162: Comment Project Location and IUCN Sections. #1072
Conversation
* Comment out Project Location App Create/Edit/View. SIMSBIOHUB-162 * Comment out Project IUCN App Create/Edit/View. * Update Survey Study Area to be required.
Openshift URLs for the PR Deployment: |
Codecov Report
@@ Coverage Diff @@
## dev #1072 +/- ##
==========================================
+ Coverage 66.30% 66.31% +0.01%
==========================================
Files 406 406
Lines 12646 12633 -13
Branches 2040 2039 -1
==========================================
- Hits 8385 8378 -7
+ Misses 3743 3738 -5
+ Partials 518 517 -1
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Openshift URLs for the PR Deployment: |
…into SIMSBIOHUB-161-162
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good 🌾
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. +1 for linking the ticket
SonarCloud Quality Gate failed. 0 Bugs No Coverage information Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
This is ready for review, I just haven't opened it yet to save OpenShift resources
Links to Jira Tickets
https://apps.nrs.gov.bc.ca/int/jira/browse/SIMSBIOHUB-161
https://apps.nrs.gov.bc.ca/int/jira/browse/SIMSBIOHUB-162
Description of Changes
SIMSBIOHUB-161/162
SIMSBIOHUB-162
Testing Notes
View/Create/Edit project should function as normal.
Will open this as a real PR once others get closed, so we don't run out of Openshift resources.