Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-161/162: Comment Project Location and IUCN Sections. #1072

Merged
merged 7 commits into from
Aug 23, 2023

Conversation

NickPhura
Copy link
Collaborator

@NickPhura NickPhura commented Aug 18, 2023

This is ready for review, I just haven't opened it yet to save OpenShift resources

Links to Jira Tickets

https://apps.nrs.gov.bc.ca/int/jira/browse/SIMSBIOHUB-161
https://apps.nrs.gov.bc.ca/int/jira/browse/SIMSBIOHUB-162

Description of Changes

SIMSBIOHUB-161/162

  • Comment out Project Location App Create/Edit/View.
    • I left the map on the Project View page, because I think we might end up changing it to show all survey boundaries instead. Can remove it entirely easily enough if not.

SIMSBIOHUB-162

  • Comment out Project IUCN App Create/Edit/View.
  • Update Survey Study Area to be required.

Testing Notes

View/Create/Edit project should function as normal.

Will open this as a real PR once others get closed, so we don't run out of Openshift resources.

* Comment out Project Location App Create/Edit/View.

SIMSBIOHUB-162
* Comment out Project IUCN App Create/Edit/View.
* Update Survey Study Area to be required.
@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #1072 (c8e5e9d) into dev (759c41b) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              dev    #1072      +/-   ##
==========================================
+ Coverage   66.30%   66.31%   +0.01%     
==========================================
  Files         406      406              
  Lines       12646    12633      -13     
  Branches     2040     2039       -1     
==========================================
- Hits         8385     8378       -7     
+ Misses       3743     3738       -5     
+ Partials      518      517       -1     
Files Changed Coverage Δ
...src/features/projects/create/CreateProjectForm.tsx 71.42% <ø> (+4.76%) ⬆️
app/src/features/projects/edit/EditProjectForm.tsx 0.00% <ø> (ø)
app/src/features/projects/view/ProjectDetails.tsx 33.33% <ø> (ø)
app/src/features/projects/view/ProjectPage.tsx 10.00% <ø> (ø)
...ures/projects/view/components/LocationBoundary.tsx 4.83% <0.00%> (+0.07%) ⬆️
.../src/features/surveys/components/StudyAreaForm.tsx 100.00% <ø> (ø)
app/src/features/surveys/view/SurveyPage.tsx 14.28% <0.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@NickPhura NickPhura added the Early Feedback Welcome PR is not finished, but early review feedback is welcomed label Aug 21, 2023
@NickPhura NickPhura marked this pull request as ready for review August 22, 2023 22:49
@NickPhura NickPhura removed the Early Feedback Welcome PR is not finished, but early review feedback is welcomed label Aug 22, 2023
Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 🌾

Copy link
Contributor

@curtisupshall curtisupshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. +1 for linking the ticket

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 12 Code Smells

No Coverage information No Coverage information
33.3% 33.3% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@NickPhura NickPhura merged commit 5f9e00e into dev Aug 23, 2023
@NickPhura NickPhura deleted the SIMSBIOHUB-161-162 branch August 23, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants