Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SIMSBIOHUB-169: Project User Roles #1075

Merged
merged 90 commits into from
Aug 28, 2023
Merged

SIMSBIOHUB-169: Project User Roles #1075

merged 90 commits into from
Aug 28, 2023

Conversation

al-rosenthal
Copy link
Contributor

Links to Jira Tickets

SIMSBIOHUB-169

Description of Changes

  • new UI for searching/ adding users to a project with a role
  • Create/ Edit endpoints, services and repos updates for new project user roles

Testing Notes

  • Create a project (add some users and roles)
  • Edit that project (modify those users and roles)

al-rosenthal and others added 30 commits August 17, 2023 11:06
@al-rosenthal
stubbed out api requests
bd35336
@al-rosenthal
added new user add section to project
fc1c178
@al-rosenthal
added types to function
8550716
@al-rosenthal
stubbed out basic add user role to project form
fdc99ad
@KjartanE
refactor service/repo/endpoint
f82aed8
@NickPhura
SIMSBIOHUB-250
1570e81 
Add user search endpoint.
Update User type definition.
@al-rosenthal
stubbed out more changes
14eb109
@NickPhura
Merge branch 'SIMSBIOHUB-250' into SIMSBIOHUB-169
68e0c54
@al-rosenthal
Merge branch 'SIMSBIOHUB-169' into SearchUI
624dbff
@al-rosenthal
updated logger path
13591f1
@al-rosenthal
added new interface for user search
05c8af2
@al-rosenthal
user search autocomplete stubbed in
fdda8c7
@al-rosenthal
filtered out selected users from dropdown
ba35b75
@al-rosenthal
selected users are now displaying
3f776ed
@NickPhura
Fix project service/project participation service tests
404b1b8
@NickPhura
Merge branch 'SIMSBIOHUB-169' of https://github.com/bcgov/biohubbc in…
b3ac687 
…to SIMSBIOHUB-169
@al-rosenthal
user list wired up
cda0dd2
@al-rosenthal
adding user roles to project form
a481c59
@al-rosenthal
project participant form is validating
6ab100b
@NickPhura
SIMSBIOHUB-256: Refactor project participation endpoints/services/rep…
72411ab 
…ositories
@al-rosenthal
started updating API
eb44a40
@KjartanE
Merge remote-tracking branch 'origin/SearchUI' into SIMSBIOHUB-169
08a17b7
@KjartanE
rework api for project create
46bb4e8
@NickPhura
Merge remote-tracking branch 'origin/SIMSBIOHUB-169' into SIMSBIOHUB-256
0b279c3
@NickPhura
Resolve merge
f099382
@NickPhura
Update
8237398
@al-rosenthal
adding validation errors to UI
7fd9369
@al-rosenthal
refactoring form into reusable components
6f38a5e
@al-rosenthal
pulled components out into generic types
409af34
@NickPhura
Moar Changes
54de713
al-rosenthal and others added 19 commits August 25, 2023 11:50
@al-rosenthal al-rosenthal removed the Early Feedback Welcome PR is not finished, but early review feedback is welcomed label Aug 28, 2023
@al-rosenthal al-rosenthal marked this pull request as ready for review August 28, 2023 20:35
@github-actions
Copy link

Openshift URLs for the PR Deployment:

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 11 Code Smells

No Coverage information No Coverage information
4.0% 4.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

KjartanE
KjartanE approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@KjartanE KjartanE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐈

@NickPhura
Copy link
Collaborator

Gave it a run locally, seems to work well. All of the different error states for the project user control are really slick.

@al-rosenthal al-rosenthal merged commit 2496f04 into dev Aug 28, 2023
@al-rosenthal al-rosenthal deleted the SearchUI branch August 28, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KjartanE KjartanE KjartanE approved these changes

@NickPhura NickPhura NickPhura approved these changes

@curtisupshall curtisupshall Awaiting requested review from curtisupshall

@GrahamS-Quartech GrahamS-Quartech Awaiting requested review from GrahamS-Quartech

@JeremyQuartech JeremyQuartech Awaiting requested review from JeremyQuartech

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@al-rosenthal @NickPhura @KjartanE @jeznorth