Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-158: Move Partnerships from Projects to Surveys #1076

Merged
merged 29 commits into from
Aug 29, 2023

Conversation

curtisupshall
Copy link
Contributor

@curtisupshall curtisupshall commented Aug 24, 2023

Links to Jira Tickets

Description of Changes

  • Removes old database tables and adds two new tables:
    • survey_first_nations_partnership
    • survey_stakeholder_partnership
  • Migrates all project partnerships to each project's surveys. (Partnerships for project that don't have surveys will be lost.)
  • Moves UI components to survey create, edit and details page
  • Creates new API service and repo methods

@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #1076 (60451c0) into dev (2496f04) will increase coverage by 0.08%.
The diff coverage is 61.26%.

@@            Coverage Diff             @@
##              dev    #1076      +/-   ##
==========================================
+ Coverage   64.10%   64.19%   +0.08%     
==========================================
  Files         435      435              
  Lines       13283    13288       +5     
  Branches     2129     2128       -1     
==========================================
+ Hits         8515     8530      +15     
+ Misses       4250     4238      -12     
- Partials      518      520       +2     
Files Changed Coverage Δ
api/src/database/db.ts 78.63% <ø> (ø)
api/src/models/project-create.ts 80.00% <ø> (-1.82%) ⬇️
api/src/models/project-update.ts 100.00% <ø> (ø)
api/src/models/project-view.ts 100.00% <ø> (ø)
api/src/models/survey-view.ts 86.76% <ø> (ø)
api/src/openapi/schemas/project.ts 100.00% <ø> (ø)
api/src/paths/project/{projectId}/survey/create.ts 96.15% <ø> (ø)
...hs/project/{projectId}/survey/{surveyId}/update.ts 96.29% <ø> (ø)
...aths/project/{projectId}/survey/{surveyId}/view.ts 95.83% <ø> (ø)
api/src/paths/project/{projectId}/update.ts 91.37% <ø> (-0.15%) ⬇️
... and 19 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@curtisupshall curtisupshall added the Early Feedback Welcome PR is not finished, but early review feedback is welcomed label Aug 25, 2023
@NickPhura
Copy link
Collaborator

A few minor comments, but looks good in general!

@NickPhura
Copy link
Collaborator

@curtisupshall Getting an error when I try to edit a project:
image

Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It migrates partnerships to surveys properly but I am unable to delete a project/ survey.

From the log when trying to delete a project:
image

Edit: pushed a fix up for this

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
2.6% 2.6% Duplication

Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@curtisupshall curtisupshall merged commit 39065a7 into dev Aug 29, 2023
@curtisupshall curtisupshall deleted the SIMSBIOHUB-158 branch August 29, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Early Feedback Welcome PR is not finished, but early review feedback is welcomed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants