Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-176: User Selection (Survey Team) #1078

Merged
merged 129 commits into from
Aug 29, 2023
Merged

SIMSBIOHUB-176: User Selection (Survey Team) #1078

merged 129 commits into from
Aug 29, 2023

Conversation

KjartanE
Copy link
Contributor

@KjartanE KjartanE commented Aug 28, 2023

Links to Jira Tickets

Description of Changes

  • updated survey Create and Edit page to include survey team member select.

Testing Notes

  • Create and Edit Survey and include addition/subtraction/edit of a survey user with a job

al-rosenthal and others added 30 commits August 17, 2023 11:06
Add user search endpoint.
Update User type definition.
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #1078 (2b5643b) into dev (39065a7) will increase coverage by 0.12%.
The diff coverage is 53.73%.

@@            Coverage Diff             @@
##              dev    #1078      +/-   ##
==========================================
+ Coverage   64.19%   64.31%   +0.12%     
==========================================
  Files         435      440       +5     
  Lines       13288    13501     +213     
  Branches     2128     2147      +19     
==========================================
+ Hits         8530     8683     +153     
- Misses       4238     4288      +50     
- Partials      520      530      +10     
Files Changed Coverage Δ
api/src/models/survey-view.ts 86.76% <ø> (ø)
api/src/paths/codes.ts 100.00% <ø> (ø)
api/src/paths/project/{projectId}/survey/create.ts 96.15% <ø> (ø)
...hs/project/{projectId}/survey/{surveyId}/update.ts 96.29% <ø> (ø)
...roject/{projectId}/survey/{surveyId}/update/get.ts 84.37% <ø> (ø)
api/src/services/code-service.ts 100.00% <ø> (ø)
app/src/components/user/UserRoleSelector.tsx 10.00% <0.00%> (ø)
app/src/features/surveys/CreateSurveyPage.tsx 2.98% <ø> (ø)
app/src/features/surveys/edit/EditSurveyForm.tsx 0.00% <0.00%> (ø)
app/src/features/surveys/edit/EditSurveyPage.tsx 0.00% <0.00%> (ø)
... and 19 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

NickPhura
NickPhura previously approved these changes Aug 29, 2023
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
11.9% 11.9% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@KjartanE KjartanE merged commit 105829d into dev Aug 29, 2023
@KjartanE KjartanE deleted the SIMSBIOHUB-176 branch August 29, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants