BugFix - Adjust Error Handling On Survey Participation Repo Function #1080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Openshift URLs for the PR Deployment: |
NickPhura
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## dev #1080 +/- ##
==========================================
- Coverage 64.35% 64.34% -0.01%
==========================================
Files 440 440
Lines 13512 13510 -2
Branches 2151 2150 -1
==========================================
- Hits 8695 8693 -2
Misses 4287 4287
Partials 530 530
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
curtisupshall
approved these changes
Aug 31, 2023
KjartanE
pushed a commit
that referenced
this pull request
Sep 5, 2023
* Fix bad error handling on a repo function. Function was throwing on empty array, when empty array should be expected/allowed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links to Jira Tickets
n/a
Description of Changes
Fix bad error handling on a repo function. Function was throwing on empty array, when empty array should be expected/allowed.
Testing Notes
Projects/survey pages should load without error when the survey has not defined any survey level participant jobs