-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SIMSBIOHUB-192: Add Site Selection Strategy + stratums to survey form #1083
Conversation
Openshift URLs for the PR Deployment: |
Codecov Report
@@ Coverage Diff @@
## dev #1083 +/- ##
==========================================
- Coverage 64.52% 64.08% -0.44%
==========================================
Files 464 470 +6
Lines 13918 14105 +187
Branches 2199 2225 +26
==========================================
+ Hits 8980 9039 +59
- Misses 4373 4493 +120
- Partials 565 573 +8
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed some strange behavior. I created a new survey with statums but when I go to edit that same survey it prompts me with the delete stratum warning. Probably just a strange state issue with the formik loading
Noted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also noticed if you edit a survey the site selection control is empty, saving and exiting causes the site selection strategies to be deleted from the database
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐶
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐱
cb2ed3f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐱
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥈
Links to Jira Tickets
Description of Changes
Testing Notes