Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-192: Add Site Selection Strategy + stratums to survey form #1083

Merged
merged 57 commits into from
Sep 12, 2023

Conversation

curtisupshall
Copy link
Contributor

@curtisupshall curtisupshall commented Aug 31, 2023

Links to Jira Tickets

Description of Changes

  • Added survey site sampling strategies and stratums to the Create Survey and Edit Survey pages
  • Added service and repo methods for creating, updating and deleting survey site selection strategies and stratums
  • Created survey site selection strategy API schema and model properties

Testing Notes

  • TBD.

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #1083 (09d2159) into dev (9d6f347) will decrease coverage by 0.44%.
The diff coverage is 31.05%.

@@            Coverage Diff             @@
##              dev    #1083      +/-   ##
==========================================
- Coverage   64.52%   64.08%   -0.44%     
==========================================
  Files         464      470       +6     
  Lines       13918    14105     +187     
  Branches     2199     2225      +26     
==========================================
+ Hits         8980     9039      +59     
- Misses       4373     4493     +120     
- Partials      565      573       +8     
Files Changed Coverage Δ
api/src/models/survey-view.ts 83.82% <ø> (ø)
api/src/paths/codes.ts 100.00% <ø> (ø)
api/src/paths/project/{projectId}/survey/create.ts 96.15% <ø> (ø)
...hs/project/{projectId}/survey/{surveyId}/update.ts 96.29% <ø> (ø)
...aths/project/{projectId}/survey/{surveyId}/view.ts 95.83% <ø> (ø)
api/src/services/code-service.ts 100.00% <ø> (ø)
app/src/features/surveys/CreateSurveyPage.tsx 2.98% <0.00%> (ø)
...features/surveys/components/SurveyBlockSection.tsx 11.11% <ø> (ø)
app/src/features/surveys/edit/EditSurveyForm.tsx 0.00% <ø> (ø)
app/src/features/surveys/view/SurveyAnimals.tsx 5.00% <ø> (+0.45%) ⬆️
... and 13 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed some strange behavior. I created a new survey with statums but when I go to edit that same survey it prompts me with the delete stratum warning. Probably just a strange state issue with the formik loading

@curtisupshall
Copy link
Contributor Author

I noticed some strange behavior. I created a new survey with statums but when I go to edit that same survey it prompts me with the delete stratum warning. Probably just a strange state issue with the formik loading

Noted

Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also noticed if you edit a survey the site selection control is empty, saving and exiting causes the site selection strategies to be deleted from the database

al-rosenthal
al-rosenthal previously approved these changes Sep 12, 2023
Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐶

KjartanE
KjartanE previously approved these changes Sep 12, 2023
Copy link
Contributor

@KjartanE KjartanE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐱

@curtisupshall curtisupshall dismissed stale reviews from KjartanE and al-rosenthal via cb2ed3f September 12, 2023 21:42
Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐩

Copy link
Contributor

@KjartanE KjartanE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐱

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.4% 0.4% Duplication

Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants